Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix tests after migration from ElasticSearch to MySQL #6

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix tests after migration from ElasticSearch to MySQL #6

wants to merge 1 commit into from

Conversation

vmalyk
Copy link
Contributor

@vmalyk vmalyk commented Nov 26, 2019

Q A
Branch? master
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes

Short description of this Pull Request.

Changes

Fixed

  • Fixed tests after migration from Elasticsearch (Pimcore Advanced Search bundle) to mySQL in release 2.0.0

@vmalyk vmalyk closed this Nov 26, 2019
@vmalyk vmalyk deleted the hotfix/unit-tests branch November 26, 2019 20:42
@vmalyk vmalyk restored the hotfix/unit-tests branch November 27, 2019 10:44
@vmalyk vmalyk reopened this Nov 27, 2019
@bramalho
Copy link
Contributor

bramalho commented Nov 28, 2019 •
edited
Loading

Hi @vmalyk
After this change, the unit tests are failing:

1) Tests\Unit\Divante\ClassificationTreeBundle\Service\ClassificationTreeBuilderTest::testGetRootNodes
Error: Call to a member function get() on null

Please take a look at travis for more information

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vmalyk @bramalho