-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add GitHub CODEOWNERS using the existing PR review teams #1515
Conversation
using the existing PR review teams from https://github.com/orgs/DjangoGirls/teams
May I suggest here to use the same language code for a resource prefixes and translators group on GitHub? We right now have What do You think about that @aniav, @RachellCalhoun? |
One downside of this is that you can't merge anything unless there's an ack from the translation team. Sometimes there are trivial changes and it would be blocked. There is https://probot.github.io/apps/auto-assign/ but I have no experience with it. |
The group name is probably due to a confusion, as The ISO 639-1 (=two-letter) language code for the group of languages known as "Chinese" is indeed I've filed a separate issue to discuss this further: #1517 |
If I understood the documentation correctly, particularly
I'd say it isn't the case that by default, merges are blocked as long as no "code owner" has approved the PR. So I think users with write permission to the target repo would still be able to merge, even without an approval. If I understand the quoted documentation part correctly, there would be a two-step opt-in for having a blocking code owner approval requirement:
(See also steps 5 and 8 of https://help.github.com/en/articles/enabling-required-reviews-for-pull-requests) Thus, adding the CODEOWNERS file should automatically request reviews by the respective code owners, but not require approval by them for merging. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In that case let's try this and see if it helps. We can always revert.
Add GitHub CODEOWNERS using the existing PR review teams from https://github.com/orgs/DjangoGirls/teams (an idea brought up by #1271 (comment))
This will automatically request reviews of the respective teams for pull requests touching "their" files, but won't require these reviews for merging.