refactor(domain): remove obsolete date function

DmitriySevkovych · Aug 13, 2024 · a624796 · a624796
1 parent e9c8e17
commit a624796
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 15 deletions.
diff --git a/packages/domain-model/src/models/dates.model.test.ts b/packages/domain-model/src/models/dates.model.test.ts
@@ -8,7 +8,6 @@ import {
     getNextDay,
     getNextWorkday,
     getNumberOfDaysInMonth,
-    timestampFromString,
 } from './dates.model'
 
 /*
@@ -42,15 +41,6 @@ describe('Tests for dealing with dates', () => {
             }
         )
 
-        it('timestampFromString should convert to a numeric timestamp', () => {
-            // Arrange
-            const dateString = '2011-01-02'
-            // Act
-            const timestamp = timestampFromString(dateString)
-            // Assert
-            expect(typeof timestamp).toBe('number')
-        })
-
         it.each`
             dateString
             ${'1999-08-02'}

diff --git a/packages/domain-model/src/models/dates.model.ts b/packages/domain-model/src/models/dates.model.ts
@@ -74,10 +74,6 @@ export const formatDateToWords = (
     return dateString
 }
 
-export const timestampFromString = (dateString: string): number => {
-    return Date.parse(dateString)
-}
-
 export const dateFromString = (dateString: string): Date => {
     // Try to deserialize SQL date string
     let date = DateTime.fromSQL(dateString, { zone: 'utc' })
@@ -88,7 +84,9 @@ export const dateFromString = (dateString: string): Date => {
     }
 
     if (!date.isValid) {
-        console.error({ dateString, date })
+        // console.error({ dateString, date })
+        // TODO temporary hack. Needs better fallback
+        date = DateTime.fromJSDate(new Date(dateString))
     }
 
     return date.toJSDate()