Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for C# 9.0 function pointers #27

Open
petarpetrovt opened this issue Sep 16, 2020 · 3 comments
Open

Add support for C# 9.0 function pointers #27

petarpetrovt opened this issue Sep 16, 2020 · 3 comments
Labels
enhancement New feature or request

Comments

@petarpetrovt
Copy link

Currently DefaultDocumentation skips methods if they have function pointer argument.

Example:

/// ...docs
public unsafe static void SortDescending<T>(ref T p0, in int length, delegate* managed<T, T, int> comparisonPointer)
{
}
@Doraku
Copy link
Owner

Doraku commented Sep 17, 2020

Hopefully as soon as this is added into ICSharpCode.Decompiler it will pop up naturally in DefaultDocumentation, I will keep an eye on this.

@Doraku
Copy link
Owner

Doraku commented Nov 6, 2020

Fields,properties and parameters should work correctly, but it seems there is a bug in the xml documentation generated for method:

public unsafe void DummyMethodFunctionPointer(int _, delegate*<void> function) => function();

generate in xml (note the missing function pointer parameter...)

<member name="M:Dummy.DummyClass.DummyMethodFunctionPointer(System.Int32,)">

Because of this the method can't find its documentation. Since C#9 is still in preview I will wait for the official release to see if this bug is still there.

@Doraku
Copy link
Owner

Doraku commented Nov 17, 2020

waiting for dotnet/roslyn#46674 to be fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants