Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#204 Timestamp columns not updating #217

Merged
merged 2 commits into from
Dec 3, 2021
Merged

#204 Timestamp columns not updating #217

merged 2 commits into from
Dec 3, 2021

Conversation

GauravGusain98
Copy link
Contributor

@GauravGusain98 GauravGusain98 commented Dec 3, 2021 •
edited
Loading

#204

Please complete the following steps and check these boxes before filing your PR:

Types of changes

  • Bug fix (a change which fixes an issue)
  • New feature (a change which adds functionality)

Short description of what this resolves:

  • Corrected the default values for timestamp columns

Checklist:

  • I have performed a self-review of my own code.
  • The code follows the style guidelines of this project.
  • The code changes are passing the CI checks
  • I have documented my code wherever required.
  • The changes requires a change to the documentation.
  • I have updated the documentation based on the my changes.

GauravGusain98
GauravGusain98 commented Dec 3, 2021
View reviewed changes
api/mixins.py
updated_on = db.Column(
db.DateTime, server_onupdate=db.func.now(), server_default=db.func.now()
)
created_on = db.Column(db.DateTime, default=datetime.now)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested it local and it worked. The arguments we are passing were incorrect.

@GauravGusain98 GauravGusain98 changed the title Timestamp columns not updating #204 Timestamp columns not updating Dec 3, 2021
Satendra-SR
Satendra-SR approved these changes Dec 3, 2021
View reviewed changes
Copy link
Member

@Satendra-SR Satendra-SR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect.. 🎉

@Satendra-SR Satendra-SR merged commit fd6e309 into develop Dec 3, 2021
@Satendra-SR Satendra-SR deleted the feature/204-timestamp-column-not-updating branch December 3, 2021 08:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Satendra-SR Satendra-SR Satendra-SR approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@GauravGusain98 @Satendra-SR