Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reduce log reattempt count to 3 #218

Merged
merged 1 commit into from
Dec 3, 2021
Merged

Reduce log reattempt count to 3 #218

merged 1 commit into from
Dec 3, 2021

Conversation

GauravGusain98
Copy link
Contributor

@GauravGusain98 GauravGusain98 commented Dec 3, 2021 •
edited
Loading

#174

Please complete the following steps and check these boxes before filing your PR:

Types of changes

  • Bug fix (a change which fixes an issue)
  • New feature (a change which adds functionality)

Short description of what this resolves:

  • Reduce retry attempt to 3 instead of 4

Checklist:

  • I have performed a self-review of my own code.
  • The code follows the style guidelines of this project.
  • The code changes are passing the CI checks
  • I have documented my code wherever required.
  • The changes requires a change to the documentation.
  • I have updated the documentation based on the my changes.

@GauravGusain98 GauravGusain98 self-assigned this Dec 3, 2021
@GauravGusain98 GauravGusain98 changed the title minor fix Reduce log reattempt count to 3 Dec 3, 2021
GauravGusain98
GauravGusain98 commented Dec 3, 2021
View reviewed changes
api/services/transaction_log_service.py
@@ -22,7 +22,7 @@ def get_failed_webhook_transaction_log(self):
)
.filter(
models.WebhookTransactionLog.attempts
<= app.config["MAX_RETRY_ATTEMPTS_FOR_LOGS"]
< app.config["MAX_RETRY_ATTEMPTS_FOR_LOGS"]
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The count start from 0 so equals to is not needed

@GauravGusain98 GauravGusain98 merged commit e299087 into develop Dec 3, 2021
@GauravGusain98 GauravGusain98 deleted the feature/174-script-to-retry-failed-webhook branch December 3, 2021 11:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Satendra-SR Satendra-SR Satendra-SR approved these changes

Assignees

@GauravGusain98 GauravGusain98

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@GauravGusain98 @Satendra-SR