#208 Add functionality to mark user_program as complete #220
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GauravGusain98
changed the title
Satendra-SR
reviewed
Dec 12, 2021
|
|
||
| def mark_user_program_as_completed(self, JsonData): | ||
| self.set_init_data(JsonData) | ||
| self.user_program_data = models.UserProgram.get_by_user_id(self.user_id) |
There was a problem hiding this comment.
This will be futuristic, but what will happen in the case of multiple user experiences?
There was a problem hiding this comment.
get_by_user_id function give use the latest active (i.e status = in-progress) user_program.
Satendra-SR
approved these changes
Dec 12, 2021
GauravGusain98
commented
Dec 12, 2021
Comment on lines
-18
to
-20
| def get_by_user_id(self, user_id): | ||
| return self.filter(Registration.user_id == user_id).first() | ||
|
|
GauravGusain98
commented
Dec 12, 2021
Comment on lines
+10
to
+11
| if not user_program_details: | ||
| user_program_details = self.get_latest_user_program(user_id) |
There was a problem hiding this comment.
in case there is no active user_program. As we have not yet decided how we will do resign up for these users. So currently not creating a new user program for completed users.
Satendra-SR
approved these changes
Dec 12, 2021
GauravGusain98
deleted the
feature/208-mark-user-program-as-completed
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#208
Please complete the following steps and check these boxes before filing your PR:
Types of changes
Short description of what this resolves:
"is_last_content"value is"true"Checklist: