Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SA1644: DocumentationHeadersMustNotContainBlankLines #164

Closed
sharwell opened this issue Nov 18, 2014 · 4 comments
Closed

SA1644: DocumentationHeadersMustNotContainBlankLines #164

sharwell opened this issue Nov 18, 2014 · 4 comments

Comments

@sharwell
Copy link
Member

sharwell commented Nov 18, 2014

@sharwell
Copy link
Member Author

sharwell commented Aug 8, 2015

I think this rule had good intentions, but it's the wrong actual rule to use. I think we should implement this by making sure paragraphs are wrapped in block-level elements. Two spans of text are considered part of different paragraphs if there is a blank documentation line between them. An example of two paragraphs separated by a blank line can be seen in SA1616ElementReturnValueDocumentationMustHaveText.cs.

@sharwell sharwell modified the milestone: 1.0.0 RC 1 Sep 17, 2015
@sharwell
Copy link
Member Author

It doesn't look like this rule will have a champion for the RC 1 release. Since it's a relatively minor rule and even has some disagreement (from me 😉 ), I'm moving it to the Backlog milestone to deal with after the 1.0 release.

@sharwell sharwell removed the blocker label Nov 29, 2015
@sharwell sharwell modified the milestones: Backlog, 1.0.0 RC 1 Nov 29, 2015
@sharwell sharwell modified the milestones: Backlog, 1.1.0 Beta 1 Dec 17, 2015
@sharwell sharwell modified the milestones: 1.1.0, 1.1.0 Beta 1 Nov 21, 2016
@sharwell
Copy link
Member Author

@vweijsters @pdelvo Any objection to closing this rule as won't fix? It's not especially helpful for readability, and the other items discussed above are already implemented in DotNetAnalyzers/DocumentationAnalyzers.

@vweijsters
Copy link
Contributor

No objection from me. I don't find this rule very useful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants