-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Full screen image of the speaker is shown by tap on the speaker page … #119
Merged
pfedotovsky
merged 3 commits into
DotNetRu:develop
from
vladbilyk:issue_48-full-screen-speaker-image
Feb 4, 2018
Merged
Full screen image of the speaker is shown by tap on the speaker page … #119
pfedotovsky
merged 3 commits into
DotNetRu:develop
from
vladbilyk:issue_48-full-screen-speaker-image
Feb 4, 2018
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Showing meetups and sessions (DotNetRu#18) * add first fersion of meetups * Add talks for meetups * Group talks by year * Some fixes, code image add * Friends implementation * Added support for iOS build & deployment * Updated Xamarin.Forms to 2.4 (DotNetRu#25) * Updated Xamarin.Forms to 2.4.0 * Temporarily disabled AppLinks functionality to improve performance * Updated some NuGet packages * Added about DotNetRu (DotNetRu#22) * Change link to repo * Remove number of meetups in title * Disabled Mono Shared Runtime (DotNetRu#32) Disable Monon Shared Runtime due to issues with app launching * Feature/uiimprovements (DotNetRu#42) * Improved Talk page * Session time imrpovements - now showing just day, instead of some random time * Major Resharper refactorings * Embedded images (DotNetRu#43) * Optimizing project structure, moving business logic away from Mock projects * Fixed namespaces for Audit project * Use local images for speakers * Added logos for friends * Enable Fast Renderers * Removed dependendies on Mock project * UI Improvements (DotNetRu#45) * Minor UI improvements * Removed session time from UI * Moved backend logic to Audit project * Improved Meetup page UI (DotNetRu#46) Added talk section Added venue section Added talks on Speaker page * About Page (DotNetRu#47) * Fixed sharing text on talk page * Improved About Page for iOS * iOS: Friends moved to a separate tab * Fixed links on About page * Localization implementation (DotNetRu#51) * First steps to make localization * basic changes for localization * LanguageImplementation Except menu * Code clean, deleted redundant files * Little fixes * Little cleanup * some more little improvments * add saving language * delete unneeded comments * renaming * remove other languages * update ios language choose * Storageoptimizations (DotNetRu#56) * Updated XML files, improved performance * Updated Audit data - XML and images * Updated project file to reflect a new storage structure * Removed unneeded files * Bottom bar + UI improvements (DotNetRu#55) * First steps to make localization * Basic changes for localization * Code clean, deleted redundant files * /localization: bottomBar implementation * BottomBar final fixes * UI improvements * Added splashscreen, changed statusbar color etc * Code Clean up * Removing fat title * Merge branch 'develop' into feature/androidBottomBar * Moved bottom bar to nuget package * small cleanup * Changed iconpath * Removed local package * Added package from nuget * Feature/xf2.5 (DotNetRu#57) * Removed obsolete projects * Fixed displaying of speaker photos and friends * Removed unneeded components * Updated Xamarin.Forms to 2.5 * Feature/analytics (DotNetRu#60) * Added App Center analytics & crashes nuget packages * Enabled AppCenter Analytics & Crashes * Removed Google Analytics * Feature/iOSMenuFixes (DotNetRu#61) * iOS Color Fix * Fixed title in menu for iOS * Removed unneeded references, updated Android.Support Nuget packages (DotNetRu#62) Optimized NuGet dependencies * UI improvements: Speaker Details page (DotNetRu#66) * Uiimprovements4 (DotNetRu#67) * Added separate image for talks with several speakers * Meetups page: month are now in title case * Upgraded to .NET 4.6 * Friends are now sorted by number of meetups * Making bottom navigation bar look more stock (DotNetRu#75) * About Page (DotNetRu#69) * About Page improvements and fixes * Improved language change * Icon Fixes for settings page * Fixed language change * Minor language fixes * Further language improvements * Fixed solution namespaces (DotNetRu#85) * Fixed namespaces in DotNetRu.Clients.Portable * Fixed namespaces in DotNetRu.Clients.UI * Fixed namespaces in DotNetRu.Utils * Fixed namespaces in DotNetRu.iOS.UpNext * Fixed namespaces for DotNetRu.Android * Removed obsolete references * About page UI improvements (DotNetRu#84) * About page UI improvements: local images, language changing and more * ui improvements after beta DotNetRu#3 (DotNetRu#88) * UI fixes: Speaker page, translation, about page and more * Removed obsolete RootPageiOS * Updated Audit (DotNetRu#89) * Improved Twitter UI (DotNetRu#94) * Improved Twitter UI * Improved custom ListView control * Minor fixes for Live Player * Ui improvements beta 5 (DotNetRu#96) * Language change improvements, * NonScrollableListView fixes * Added DotNetRu logo on About screen * Added Meetup date on Meetups page * add divider * Fixed LinqToTwitter NuGet package (DotNetRu#98) * wrap text on image * Ui improvements beta 7 (DotNetRu#99) * Fixed Speaker image * Improved News page - simplified layout Improved NonScrollableListView Fixed Speaker page issues with talks/follow items not being displayed * Updated Android & iOS project to use PackageReference * Fix of packages.config error (DotNetRu#101) * change url * Updated NuGet packages (DotNetRu#104) * Updated all project to use Package Reference * Updated XF package * Updated several packages * Updated ALL nuget packages * Fixed crash on News page * About page: white background for about text (DotNetRu#106) * white background for grid * Fix white background for meetup page (DotNetRu#107) * Add background color for scroll view * Feature/customizing twitter look (DotNetRu#108) * Good-looking twitter page * Fixed links, images and counters * Retweet name fix * PullToRefresh fix * Increased Tweeter feed to 20 tweets * Updated Audit, fixed compilation * Feature/documentation (DotNetRu#118) * Updated Audit, fixed compilation (DotNetRu#113) * update readme & create issue template * add description and screenshots * Update README.md
Please change Pull Request to DotNetRu:develop branch |
…_48-full-screen-speaker-image # Conflicts: # DotNetRu.Clients.Portable/Model/AppPage.cs # DotNetRu.Clients.UI/DotNetRu.Clients.UI.csproj # DotNetRu.Clients.UI/Pages/Speakers/SpeakerDetailsPage.xaml.cs
I've switched PR to dev branch :) |
@vladbilyk sorry for late reply. Looks good, thank you! |
Yep! It works on iOS simulator :) |
pfedotovsky
added a commit
that referenced
this pull request
Mar 3, 2018
* Full screen image of the speaker is shown by tap on the speaker page … (#119) Full screen image of the speaker is shown by tap on the speaker page * Add information about target branch (#128) * Update README.md * Add information about gitflow * Net Standard (#130) * Removed obsolete & now deprecated Components * Updating to .NET Standard part I * Updating to .NET standard part II * Updating to .NET Standard part III * Update to .NET standard part 4 * Removed obsolete BCL packages * Temporarily disabling tweets; project now compiles successfully * Fixed getting tweets, now app is fully functional * Removed Obsolete packages, minor improvements * iOS improvements * Removed obsolete UWP solution * Added UWP project * iOS fixes * UWP: removed obsolete files * UWP: more fixes * UWP: now project compiles successfully * UWP: added splash screen * Updated several NuGet packages * Updated ALL packages; UWP fixes * Added comment about CircleTransformation & linker issue * displays twitter account full name in news page, closes #121 (#133) * Meetups list (#135) * meetups list on friends page, closes #58 * Speakers grouping and fast navigation by speakers list (index list - … (#136) * Speakers grouping and fast navigation by speakers list (index list - iOS, fast scroll - Android) were added. * Post-review commit: style changes + ordering by FirstName * Post-review commit: indentation was fixed * Improving app size & startup time (#134) * Removed unneeded icons * Removed obsolete Android 4.4 styles * Removed obsolete files, enabled ProGuard * Futher Android optimizations: getting rid of unused packages & permissions * AppSize: removing obsolete code * Android: removed unneeded Support Library * iOS size improvements * iOS: increased app version * Android: enabled AOT & LLVM to improve start up time * iOS fixed info.plist * iOS: added ARMv7s to support iPhone 5C * Android: enabled native HttpHandler & TLS to improve performance & appsize. Enabled experimental GC * Android: drop x86 support to reduce app size * iOS: fixed issue with iPhone 5, 5c support * iOS: changed ARMv7s to ARMv7 as Apple doesn't support ARMv7s anymore * iOS: project configuration fixes * Create CODE_OF_CONDUCT.md (#138) * Performance improvements (#140) * Enabled XAML compilation for all XAML files * Updated Resharper settings * Android: optimized PNG images * Android: removed unneeded references * Got rid of Newtonsoft.Json reference * Updated DotNetRu.BottomTabbedPage package - now all packages support .NET Standard 2.0 * Fixed zooming of speaker photo Updated technology used page * Added original version of BottomTabbedPage package * Removed App Analytics from Debug builds * LivePlayer fixes & Language improvements * Added Kazan * Updated Audit * Changed upcoming meetups color * Fixed layout on Friends page
pfedotovsky
added a commit
that referenced
this pull request
Apr 1, 2018
* Full screen image of the speaker is shown by tap on the speaker page … (#119) Full screen image of the speaker is shown by tap on the speaker page * Add information about target branch (#128) * Update README.md * Add information about gitflow * Net Standard (#130) * Removed obsolete & now deprecated Components * Updating to .NET Standard part I * Updating to .NET standard part II * Updating to .NET Standard part III * Update to .NET standard part 4 * Removed obsolete BCL packages * Temporarily disabling tweets; project now compiles successfully * Fixed getting tweets, now app is fully functional * Removed Obsolete packages, minor improvements * iOS improvements * Removed obsolete UWP solution * Added UWP project * iOS fixes * UWP: removed obsolete files * UWP: more fixes * UWP: now project compiles successfully * UWP: added splash screen * Updated several NuGet packages * Updated ALL packages; UWP fixes * Added comment about CircleTransformation & linker issue * displays twitter account full name in news page, closes #121 (#133) * Meetups list (#135) * meetups list on friends page, closes #58 * Speakers grouping and fast navigation by speakers list (index list - … (#136) * Speakers grouping and fast navigation by speakers list (index list - iOS, fast scroll - Android) were added. * Post-review commit: style changes + ordering by FirstName * Post-review commit: indentation was fixed * Improving app size & startup time (#134) * Removed unneeded icons * Removed obsolete Android 4.4 styles * Removed obsolete files, enabled ProGuard * Futher Android optimizations: getting rid of unused packages & permissions * AppSize: removing obsolete code * Android: removed unneeded Support Library * iOS size improvements * iOS: increased app version * Android: enabled AOT & LLVM to improve start up time * iOS fixed info.plist * iOS: added ARMv7s to support iPhone 5C * Android: enabled native HttpHandler & TLS to improve performance & appsize. Enabled experimental GC * Android: drop x86 support to reduce app size * iOS: fixed issue with iPhone 5, 5c support * iOS: changed ARMv7s to ARMv7 as Apple doesn't support ARMv7s anymore * iOS: project configuration fixes * Create CODE_OF_CONDUCT.md (#138) * Performance improvements (#140) * Enabled XAML compilation for all XAML files * Updated Resharper settings * Android: optimized PNG images * Android: removed unneeded references * Got rid of Newtonsoft.Json reference * Updated DotNetRu.BottomTabbedPage package - now all packages support .NET Standard 2.0 * Release1.0.1 (#143) * Fixed zooming of speaker photo Updated technology used page * Added original version of BottomTabbedPage package * Removed App Analytics from Debug builds * LivePlayer fixes & Language improvements * Added Kazan * Updated Audit * Changed upcoming meetups color * Fixed layout on Friends page * Create CONTRIBUTING.md (#139) * Create CONTRIBUTING.md * Update CONTRIBUTING.md * Fixed twitter feed (#146) * Realm backend (#148) * Removed no longer needed Audit files - will be replaced by single Realm file * Added Realm file * Replaced services to get data from Realm database * Updated NuGet packages * Display speaker basic info * Added fix for netstandard/android. See dotnet/android#1162 (comment) * Display meetups, backend fixes * Fix build in App Center * Display speaker details * Simplified getting talks for speaker by leveraging Realm backlink property * Replaced all manual queries with backlinking * Added friend logos * Now app displays all Audit information based on Realm database * Replaced all entity service with realm service using automapper * Attempt to fix App Center build * Cleaning up, bugfixes * Updated .gitignore * Added missing Realm file, part I * Removed obsolete directories * Attempt to fix Android build in App Center * Attempt to fix App Center build #3 * Attempt to fix iOS build * Cleaning up, increased app version to 1.1.0 * Attempt to fix iOS build #2 * Attempt to fix iOS build #3 * Rolled back to Android SDK 8.0 due to App Center issues * Cleaning up - added TwitterService & LanguageService * Android: rolled back Target Framework to Android 8.0 to fix App Center build * Fixed images on speakers page * Fixed displaying speaker avatars on Meetup page * Fixed displaying Friends logos * Removed small speaker avatar * Fixed displaying of speaker avatar * Fixed credits on about app page * Fix issue with duplicate AutoMapper initialization
pfedotovsky
added a commit
that referenced
this pull request
Jun 12, 2018
* Full screen image of the speaker is shown by tap on the speaker page … (#119) Full screen image of the speaker is shown by tap on the speaker page * Add information about target branch (#128) * Update README.md * Add information about gitflow * Net Standard (#130) * Removed obsolete & now deprecated Components * Updating to .NET Standard part I * Updating to .NET standard part II * Updating to .NET Standard part III * Update to .NET standard part 4 * Removed obsolete BCL packages * Temporarily disabling tweets; project now compiles successfully * Fixed getting tweets, now app is fully functional * Removed Obsolete packages, minor improvements * iOS improvements * Removed obsolete UWP solution * Added UWP project * iOS fixes * UWP: removed obsolete files * UWP: more fixes * UWP: now project compiles successfully * UWP: added splash screen * Updated several NuGet packages * Updated ALL packages; UWP fixes * Added comment about CircleTransformation & linker issue * displays twitter account full name in news page, closes #121 (#133) * Meetups list (#135) * meetups list on friends page, closes #58 * Speakers grouping and fast navigation by speakers list (index list - … (#136) * Speakers grouping and fast navigation by speakers list (index list - iOS, fast scroll - Android) were added. * Post-review commit: style changes + ordering by FirstName * Post-review commit: indentation was fixed * Improving app size & startup time (#134) * Removed unneeded icons * Removed obsolete Android 4.4 styles * Removed obsolete files, enabled ProGuard * Futher Android optimizations: getting rid of unused packages & permissions * AppSize: removing obsolete code * Android: removed unneeded Support Library * iOS size improvements * iOS: increased app version * Android: enabled AOT & LLVM to improve start up time * iOS fixed info.plist * iOS: added ARMv7s to support iPhone 5C * Android: enabled native HttpHandler & TLS to improve performance & appsize. Enabled experimental GC * Android: drop x86 support to reduce app size * iOS: fixed issue with iPhone 5, 5c support * iOS: changed ARMv7s to ARMv7 as Apple doesn't support ARMv7s anymore * iOS: project configuration fixes * Create CODE_OF_CONDUCT.md (#138) * Performance improvements (#140) * Enabled XAML compilation for all XAML files * Updated Resharper settings * Android: optimized PNG images * Android: removed unneeded references * Got rid of Newtonsoft.Json reference * Updated DotNetRu.BottomTabbedPage package - now all packages support .NET Standard 2.0 * Release1.0.1 (#143) * Fixed zooming of speaker photo Updated technology used page * Added original version of BottomTabbedPage package * Removed App Analytics from Debug builds * LivePlayer fixes & Language improvements * Added Kazan * Updated Audit * Changed upcoming meetups color * Fixed layout on Friends page * Create CONTRIBUTING.md (#139) * Create CONTRIBUTING.md * Update CONTRIBUTING.md * Fixed twitter feed (#146) * Realm backend (#148) * Removed no longer needed Audit files - will be replaced by single Realm file * Added Realm file * Replaced services to get data from Realm database * Updated NuGet packages * Display speaker basic info * Added fix for netstandard/android. See dotnet/android#1162 (comment) * Display meetups, backend fixes * Fix build in App Center * Display speaker details * Simplified getting talks for speaker by leveraging Realm backlink property * Replaced all manual queries with backlinking * Added friend logos * Now app displays all Audit information based on Realm database * Replaced all entity service with realm service using automapper * Attempt to fix App Center build * Cleaning up, bugfixes * Updated .gitignore * Added missing Realm file, part I * Removed obsolete directories * Attempt to fix Android build in App Center * Attempt to fix App Center build #3 * Attempt to fix iOS build * Cleaning up, increased app version to 1.1.0 * Attempt to fix iOS build #2 * Attempt to fix iOS build #3 * Rolled back to Android SDK 8.0 due to App Center issues * Cleaning up - added TwitterService & LanguageService * Android: rolled back Target Framework to Android 8.0 to fix App Center build * Fixed images on speakers page * Fixed displaying speaker avatars on Meetup page * Fixed displaying Friends logos * Removed small speaker avatar * Release 1.1.0 (#156) * Fixed displaying of speaker avatar * Fixed credits on about app page * Fix issue with duplicate AutoMapper initialization * Push notifications for Android (#165) * add xml parsing * add converting from xml model to realm * Implemented app autoupdate (without images) * Fixed issue with Rate limiting Added loading images for new speakers/friends * Improved updating speaker photos * Slightly improved updating Realm - now it's done in one transaction * Improved speed of Audit update - now 3x times faster * Set up push notifications for Android. Now app is capable of autoupdating itself on push * Set up Push Notifications for iOS * Push Notifications improvemtns: enhanced logging, background update (not working yet) * Fixed error with background update, enhanced logging for Android (logcat). Now app successfully updates Audit on background (but there's still an issue with silent pushes) * Added updating current audit version after successful update (using new table w/ commit hash) * Added Firebase SDK * Improved logging for troubleshooting Firebase issues * Push Notifications improvements - [Android] Added displaying local notification after successful update - Added Realm overwrite after each app update (actual for release builds) - Fixed build & run issues due to outdated Firebase package * Fixed AppCenter build issue * Fixed incorrect AppCenter.Crashes reference * Updated ALL nuget packages * [Android] Added support for Notification channels * [Android] Added Firebase specific notification handler * [Android] Rolled back to Android 8.0 due to App Center issues * - Fixed issues with threading & Realm due to lack of synchronization context - Improved AutoMapper configuration to avoid issues with multiple updates - Now pushes on Android work just fine independing of app state (background or foreground) * [Android] Removed App Center Push as Firebase is used now * iOS: increased version to 1.2.0 * [Android] Fixed App Center issue with targetSDK not being set * [iOS] Attempt to fix issue with notification handling - Missing type DateTimeOffsetConverter * [Android] Fixed issue with notification on Android < 8.0 [iOS] Added initial Firebase SDK * [Android] moved notification related logic to one place * Changing Settings page to TableView * [iOS] Removed Firebase package. APNS will be used instead * Updating Settings page * [Android] Fixed build in version of Visual Studio (15.7.1) * Replacing ListView in Settings page with custom viewcells * Replaced listview with custom cells in Settings page * Fixed translation for communities items * Added background color for text cells * Removed XfGloss due to bugs * Fixed opening Friends Added WhitetextCell control * Renamed Android channelID to new meetup * Android. Improved Settings page * [Android] Add notification icon, changed text, add auto-cancel * Updated Audt * Added missing localization * Removed hack realted to .NET standard as new version of Xamarin handles .NET Standard properly * Added pre-build script to change App Center key * Moved pre-build script to Android project * Attempt to fix pre-build file path issue * Attempt to fix issues with pre-build script * Dummy build to test App Center * Changed enconing to UTF-8 * pre-build script: added part to replace App Center configs * pre-build script: removed unneeded option * Attempt to fix pre-build script in AppCenter * Attempt to fix pre-build script * Changed pre-build script to only master branch & production config
pfedotovsky
pushed a commit
that referenced
this pull request
Jul 20, 2018
#119) Full screen image of the speaker is shown by tap on the speaker page
pfedotovsky
added a commit
that referenced
this pull request
Oct 29, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…(#48)