Improve tests for Downloader.destination_for

DragonBox · Jan 6, 2018 · 571559f · 571559f
1 parent 772f9b7
commit 571559f
Show file tree

Hide file tree

Showing 2 changed files with 60 additions and 3 deletions.
diff --git a/spec/spec_helper.rb b/spec/spec_helper.rb
@@ -53,6 +53,12 @@ def with_env_values(hash)
   end
 end
 
+def warn_if_env(variable)
+  if ENV[variable] && !ENV[variable].empty?
+    puts "[WARNING] Environment variable #{variable} should not be assigned during testing. Results may be affected."
+  end
+end
+
 def capture_stds
   require "stringio"
   orig_stdout = $stdout

diff --git a/spec/u3d/downloader_spec.rb b/spec/u3d/downloader_spec.rb
@@ -386,7 +386,8 @@
       end
 
       describe '.destination_for' do
-        it 'returns the correct destination the Unity installer' do
+        it 'returns the correct default destination for the specified package' do
+          warn_if_env('U3D_DOWNLOAD_PATH')
           expect(U3d::Utils).to receive(:ensure_dir) {}
           allow(U3d::INIparser).to receive(:load_ini) { { 'Unity' => { 'url' => 'http://download.unity3d.com/download_unity/linux/unity-editor-installer-1.2.3f4+20160628.sh' } } }
 
@@ -399,6 +400,22 @@
             )
           ).to eql File.join(ENV['HOME'], 'Downloads', 'Unity_Packages', '1.2.3f4', 'unity-editor-installer-1.2.3f4+20160628.sh')
         end
+
+        it 'returns the custom destination for the specified package when the environment variable is specified' do
+          with_env_values('U3D_DOWNLOAD_PATH' => '/foo') do
+            expect(U3d::Utils).to receive(:ensure_dir) {}
+            allow(U3d::INIparser).to receive(:load_ini) { { 'Unity' => { 'url' => 'http://download.unity3d.com/download_unity/linux/unity-editor-installer-1.2.3f4+20160628.sh' } } }
+
+            definition = U3d::UnityVersionDefinition.new('1.2.3f4', :linux, nil)
+
+            expect(
+              @downloader.destination_for(
+                'Unity',
+                definition
+              )
+            ).to eql File.join(File.expand_path('/foo'), '1.2.3f4', 'unity-editor-installer-1.2.3f4+20160628.sh')
+          end
+        end
       end
 
       describe '.url_for' do
@@ -422,7 +439,8 @@
       end
 
       describe '.destination_for' do
-        it 'returns the correct destination the specified package' do
+        it 'returns the correct default destination for the specified package' do
+          warn_if_env('U3D_DOWNLOAD_PATH')
           expect(U3d::Utils).to receive(:ensure_dir) {}
           allow(U3d::INIparser).to receive(:load_ini) { { 'package' => { 'url' => 'MacEditorInstaller/Unity.pkg' } } }
 
@@ -435,6 +453,22 @@
             )
           ).to eql File.join(ENV['HOME'], 'Downloads', 'Unity_Packages', '1.2.3f4', 'Unity.pkg')
         end
+
+        it 'returns the custom destination for the specified package when the environment variable is specified' do
+          with_env_values('U3D_DOWNLOAD_PATH' => '/foo') do
+            expect(U3d::Utils).to receive(:ensure_dir) {}
+            allow(U3d::INIparser).to receive(:load_ini) { { 'package' => { 'url' => 'MacEditorInstaller/Unity.pkg' } } }
+
+            definition = U3d::UnityVersionDefinition.new('1.2.3f4', :mac, nil)
+
+            expect(
+              @downloader.destination_for(
+                'package',
+                definition
+              )
+            ).to eql File.join(File.expand_path('/foo'), '1.2.3f4', 'Unity.pkg')
+          end
+        end
       end
 
       describe '.url_for' do
@@ -458,7 +492,8 @@
       end
 
       describe '.destination_for' do
-        it 'returns the correct destination the specified package' do
+        it 'returns the correct default destination the specified package' do
+          warn_if_env('U3D_DOWNLOAD_PATH')
           expect(U3d::Utils).to receive(:ensure_dir) {}
           allow(U3d::INIparser).to receive(:load_ini) { { 'package' => { 'url' => 'Windows64EditorInstaller/UnitySetup64.exe' } } }
 
@@ -471,6 +506,22 @@
             )
           ).to eql File.join(ENV['HOME'], 'Downloads', 'Unity_Packages', '1.2.3f4', 'UnitySetup64.exe')
         end
+
+        it 'returns the custom destination for the specified package when the environment variable is specified' do
+          with_env_values('U3D_DOWNLOAD_PATH' => '/foo') do
+            expect(U3d::Utils).to receive(:ensure_dir) {}
+            allow(U3d::INIparser).to receive(:load_ini) { { 'package' => { 'url' => 'Windows64EditorInstaller/UnitySetup64.exe' } } }
+
+            definition = U3d::UnityVersionDefinition.new('1.2.3f4', :win, nil)
+
+            expect(
+              @downloader.destination_for(
+                'package',
+                definition
+              )
+            ).to eql File.join(File.expand_path('/foo'), '1.2.3f4', 'UnitySetup64.exe')
+          end
+        end
       end
 
       describe '.url_for' do