-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
u3d/install: find all patched versions #172
Comments
Hey @marklonquist ! I just took a look at your issue and I understand where it comes from, we only look for the patches on the first page of the patches list of unity, and the two versions you are talking about are on other pages! Right now, I'm not sure I can fix it:
Nonetheless, if you want to try to tackle it yourself, you could fiddle with this and iterate over the pages (at https://unity3d.com/fr/unity/qa/patch-releases?page= |
Thanks @niezbop I'll dig around :-) |
Another thing to take into account, we need to filter versions < 5 from the list of patch versions. |
Just a quick thought; When running the install command, wouldn't it be possible to simple check for the version using a more direct method? If version contains "p", check if it exist by simply using the version in this URL: |
I would prefer if we fill the cache properly and not change the logic too much. We have a task to move the generation of the cache online (#142). That way u3d will download_cache and then install. |
yea that would fix the issue. I'll try to make a hacky fix for my own setup until #142 is implemented. |
@marklonquist here's something that might help
|
u3d/available: discover all patched releases (fixes #172)
@marklonquist solved in 1.0.9, freshly released. |
@marklonquist you will be happy to know that u3d available is almost instantaneous thanks to the u3d available improvements in 1.0.13. We fetch the information from a centralized cache. |
Sounds awesome :) Will update our building machine. Thanks for letting me know. |
Hi
I've had a few issues where u3d can't find the version of the project in the list of available versions.
This results in time spent on manual installation 😢
Latest issue with; 5.6.3p4. Also happened with version 2017.1.0p4.
The text was updated successfully, but these errors were encountered: