error: Net::ReadTimeout

[stelcheck]

Issue Checklist

• I'm using the latest u3d version
• I ran u3d --help
• I read the README
• I made sure that a similar issue doesn't exit

Issue Description

ruby 2.5.0p0 (2017-12-25 revision 61468) [x86_64-linux]

Trying to install a Unity version on Linux, but I always end up with the following:

Root privileges are required
Password for censored:
****************
No credentials storage available
--------------------------------------------
--- Downloading Unity version 2017.1.2f1 ---
--------------------------------------------
Downloading from http://beta.unity3d.com/download/7598623e6ed6/./unity-editor-installer-2017.1.2f1.sh
Download will be found at /home/censored/Downloads/Unity_Packages/2017.1.2f1/unity-editor-installer-2017.1.2f1.sh
[=====>..............] 849.95 MiB/2.63 GiB (31.6% at 7.94 MiB/s)     error: Net::ReadTimeout. Use --trace to view backtrace

The network appears to be perfectly fine, so I am not sure what might be the issue. It would be nice if we could have the tool resume past download so that I may eventually be able to complete the download.

[lacostej]

Thanks @stelcheck we will look into adding retries.

[lacostej]

@stelcheck could you try the version I uploaded on my repo?

after installing it, the default timeout should be now 5 min instead of 1. You can also modify it using environment variables

U3D_HTTP_MAX_RETRIES=5 U3D_HTTP_READ_TIMEOUT=600 u3d install --no-install 2018.1.0b9 --verbose

[lacostej]

If you need help on how to install that particular version, let us know. I will make a release based on this in a few days.

[stelcheck]

I'll try to test this in the upcoming days. However, if I may make one recommendation, it may be wiser to lower the default timeout value and increase the number of retries.

I also couldn't find any documentation regarding Net:HTTP.start, is max_retries trying to continue the download from where we are at or will it restart the download from the beginning?

[stelcheck]

Quick update: timeout does seem to work properly, but I don't have a good test case for testing retries. Any suggestions?

[lacostej]

max_retries: https://github.com/ruby/ruby/blob/trunk/lib/net/http.rb#L1511

[lacostej]

Note that max_retries is ruby 2.5+ so we may want to add a mechanism to do the same thing in u3d itself for ruby < 2.5.

[stelcheck]

TBH I don't see any down sides requiring 2.5+. I know of a few bugs in fastlane where the solution was to use 2.5, and I'd expect this tool will be heavily used with that.