ud3/prettify: improve exception logging rules #118
Conversation
| @@ -24,10 +24,10 @@ | |||
| }, | |||
| "exception": { | |||
| "active": true, | |||
| "start_pattern": "[eE]xception.*: (?<message>.*)\\n", | |||
| "end_pattern": "Filename: (?:[\\w/:]+/(?<file>\\w+\\.\\w+))? Line: (?<line>-?\\d+)", | |||
| "start_pattern": "[eE]xception\\w*: (?<message>.*)\\n", | |||
There was a problem hiding this comment.
This will only match Exception throwing now
| "start_pattern": "[eE]xception.*: (?<message>.*)\\n", | ||
| "end_pattern": "Filename: (?:[\\w/:]+/(?<file>\\w+\\.\\w+))? Line: (?<line>-?\\d+)", | ||
| "start_pattern": "[eE]xception\\w*: (?<message>.*)\\n", | ||
| "end_pattern": "(?:Filename: (?:[\\w/:]+/(?<file>\\w+\\.\\w+))? Line: (?<line>-?\\d+)|(?<fileunknown>filename unknown)>:(?<lineunknown>-?\\d+))", | ||
| "start_message": false, |
There was a problem hiding this comment.
Add alternative ending for exception thrown from unknown files
|
Could we add some tests, either unit or integration to start covering for those cases? |
|
I'm not sure this is easily doable. Theses fixes are for edge cases that should occur quite rarely. If we want those to be covered we need an extensive log base for most (if not every) things doable with the Unity Editor and make sure and isolate the rule and challenge the log base, making sure that it only catches what was intended (how would you define that correctly?) and nothing else. In this precise case, issues appeared when I was
|
|
If we don't have a set of test to go against, we will have a hard time refactoring the rules file without breaking it. |
|
Agreed. I'm opening an issue for that then as I believe this should be done in a separate PR. Better start collecting logs! |
|
Approved. Don't forget to make a better PR message for the changelog. Thanks! |
lacostej
changed the title
lacostej
changed the title
lacostej
changed the title
lacostej
changed the title
Restrict rule start to actual exceptions and prevent it from firing on other log with exceptions (for instance on updating/loading/building custom exception classes).
Adds alternative end condition to exception rule when the file that raised the exception is unknown (ThreadAbortException for example).