Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

u3d/downloader: print progress improvements (fix #164) #177

Merged
merged 4 commits into from
Nov 2, 2017
Merged

u3d/downloader: print progress improvements (fix #164) #177

merged 4 commits into from
Nov 2, 2017

Conversation

lacostej
Copy link
Member

@lacostej lacostej commented Oct 31, 2017 •
edited
Loading

Always use the server declared size first, and force printing when done.

This should solve inaccurate Windows package sizes and fix #164

@lacostej lacostej requested a review from niezbop October 31, 2017 21:30
niezbop
niezbop reviewed Nov 2, 2017
View reviewed changes
Copy link
Member

@niezbop niezbop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Trying that right now

niezbop
niezbop requested changes Nov 2, 2017
View reviewed changes
Copy link
Member

@niezbop niezbop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It does not work, but I guess this may be due to some format errors I'll try to solve this and will PR your branch

@niezbop
Copy link
Member

niezbop commented Nov 2, 2017

capture d ecran 4

@lacostej lacostej changed the title u3d/downloader: always use the server declared size first, to work around inaccurate Windows package sizes (fixes #164) u3d/downloader: always use the server declared size first, and force printing when done. This should solve inaccurate Windows package sizes and fix #164 Nov 2, 2017
@lacostej lacostej changed the title u3d/downloader: always use the server declared size first, and force printing when done. This should solve inaccurate Windows package sizes and fix #164 u3d/downloader: print progress improvements (fix #164) Nov 2, 2017
@niezbop
Copy link
Member

niezbop commented Nov 2, 2017

Works for me!

@lacostej lacostej merged commit 3a3c967 into DragonBox:master Nov 2, 2017
@lacostej lacostej deleted the win_size branch November 2, 2017 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@niezbop niezbop niezbop approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

u3d/download progress bar on Windows not going to 100%
2 participants
@lacostej @niezbop