u3d/available: allow to match using regular expression #216
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
niezbop
reviewed
Jan 8, 2018
| module Extractable | ||
| refine Hash do | ||
| def extract(*keys) | ||
| select { |k, _v| keys.include?(k) } |
There was a problem hiding this comment.
def extract(*args)
self.keys & args
endThis may be cleaner?
There was a problem hiding this comment.
Oops, maybe not. This should though:
def extract(*args)
keys & args
end
lacostej
force-pushed
the
available_version_matcher
branch
from
8eada60 to
cc677aa
Compare
niezbop
approved these changes
Jan 8, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
requires #215 to be merged. I will rebase when ready.