u3d/install: allow to download from one platform while on another one #226
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
niezbop
reviewed
Jan 15, 2018
lib/u3d/commands.rb
Outdated
| @@ -103,7 +103,8 @@ def list_available(options: {}) | |||
| def install(args: [], options: {}) | |||
| version = specified_or_current_project_version(args[0]) | |||
|
|
|||
| os = U3dCore::Helper.operating_system | |||
| UI.user_error!("install can only work with current operating system. You specified #{options[:operating_system]}") if options[:install] && options[:operating_system] | |||
There was a problem hiding this comment.
I would maybe specify the use of the --no-install here
There was a problem hiding this comment.
At this point I don't know if the user specified install explicitly or if it was the default.
Is this better?
UI.user_error!("You cannot use the --operating_system and the --install options together") if options[:install] && options[:operating_system]
lib/u3d/commands_generator.rb
Outdated
| @@ -139,10 +140,12 @@ def run | |||
| c.option '--[no-]download', 'Perform or not downloading before installation. Downloads by default' | |||
| c.option '--[no-]install', 'Perform or not installation after downloading. Installs by default' | |||
| c.option '-p', '--packages PACKAGES', Array, 'Specifies which packages to download/install. Overriden by --all' | |||
| c.option '-o', '--operating_system STRING', String, "Downloads packages for specific OS [#{oses.join(', ')}]" | |||
There was a problem hiding this comment.
We could say here as well that this is a precision for --no-install. Something like Requires the --no-install option
|
I think we should be a bit clearer regarding this option, and clearly state that this is a focus for |
lacostej
force-pushed
the
download_other_platform
branch
from
ed71443 to
2c644ba
Compare
|
Simple change that allowed me to implement part of the #227 from my Mac :) |
niezbop
approved these changes
Jan 15, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.