u3d/install: add support for installing .msi packages on Windows #230
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lacostej
reviewed
Jan 15, 2018
lib/u3d/installer.rb
Outdated
| @@ -311,7 +311,11 @@ def install_exe(file_path, installation_path: nil, info: {}) | |||
| command = nil | |||
| if info['cmd'] | |||
| command = info['cmd'] | |||
| command.sub!(/{FILENAME}/, file_path) | |||
| if /msiexec/ =~ command | |||
| command.sub!(/{FILENAME}/, '"' + file_path.gsub(%r{\/(\d)}, '/\\\\\1').tr('/', '\\') + '"') | |||
There was a problem hiding this comment.
turn this into a private method?
windows_path(file_path) or something?
There was a problem hiding this comment.
Maybe put in utils?
This could be reusable
There was a problem hiding this comment.
as you wish. At least extract it from here to that we can understand what happens without decrypting the code :)
lacostej
changed the title
|
I just realized that in the same file we already do some windows sanitization. In a different way: |
|
Oh right. Well this is not the good way then, let me change that. The issue we had was when sub was called with |
lacostej
approved these changes
Jan 15, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for downloading and installing .msi packages for Windows.