u3d/install: improve messages #231
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lacostej
reviewed
Jan 15, 2018
| @@ -63,7 +63,8 @@ def self.sanitize_installs(installer) | |||
| def self.install_modules(files, version, installation_path: nil) | |||
| installer = Installer.create | |||
| files.each do |name, file, info| | |||
| UI.verbose "Installing #{name}#{info['mandatory'] ? ' (mandatory package)' : ''}, with file #{file}" | |||
There was a problem hiding this comment.
We could use info['title'] as well somewhere.
Note: do this make the console much more verbose?
There was a problem hiding this comment.
Regarding verbose, this adds a few extra lines, but I really feel like the added cost is overweight by the increase readability, ie
Before:
$ C:/Users/pniez/Downloads/Unity_Packages/2018.1.0b2/UnitySetup64.exe -UI=reduced /S /D=C:\Program Files\Unity_2018.1.0b2
No pty implementation found. Falling back to popen. Output might be buffered
Successfully installed Unity 2018.1.0b2
After:
--------------------------------
--- Installing Documentation ---
--------------------------------
Installing with C:/Users/pniez/Downloads/Unity_Packages/2017.1.2f1/UnityDocumentationSetup.exe
$ C:/Users/pniez/Downloads/Unity_Packages/2017.1.2f1/UnityDocumentationSetup.exe /S /D=C:\Program Files\Unity_2017.1.2f1
No pty implementation found. Falling back to popen. Output might be buffered
Successfully installed Documentation
WDYT?
lacostej
approved these changes
Jan 15, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This improves the output of the installer by making it more obvious what is happening, and make it similar to the downloader output.