u3d/dependencies: add command to install Linux dependencies #25

niezbop · 2017-08-05T17:53:24Z

Before installing Unity on Linux, the installer will now install its required dependencies.

lacostej · 2017-08-05T19:06:28Z

A few things make me uncertain about how the current proposal

we force install of the dependencies everytime we try to install. Dependencies are (to my knowledge) for running the editor. Do we need them for installation?
we force install of the dependencies everytime we try to install and regardless if the dependencies are there already
we fail hard if we don't recognize the platform (deb/yum-rpm). This prevents installing unity completely on those systems
the check dev vs rpm doesn't allow us to ensure you are on the right platform (if for example you can install dpkg on a rpm based platform).
Fedora migrated to dnf. Not sure how that works there.

I would like this to be tested heavily on various systems. Maybe implemented as a separate command (u3d install-editor-deps [--type deb/rpm] ?

niezbop · 2017-08-05T23:36:26Z

I agree it is a peculiar feature to have. Missing libraries did indeed have no effect on whether the installer completed its job.

Short answer no, but what good is it to install something that won't work?
That's why I thought that validation for each library would be better, as a user could specify to skip some of them, knowing they're already present, or not willing to update them.
Alternatively, we could either keep track of what has been installed or try to fetch installed libraries before trying to install them.
return and UI.error then?
I'm not sure there is a really better way, it seems to be a well known check. The usecases of people having installed dpkg on a rpm-based os (which has no point as .deb files are Debian specific) is too small (in my opinion at least) to have an impact on this. Then again, there may be a far better check that I'm not aware of! Nothing is written in stone anyways, so my current check could be swapped easily.
I'll try to find a solution for that

This could be a good idea indeed. Especially if we consider the added dependencies needed to build to WebGL or to Tizen/Android, which could be specified in such a command as well.

lacostej · 2017-08-06T21:58:33Z

Notes for self: detect if something is to be installed on Debian derivative:

$ sudo apt-get install -s maven | grep "^Inst"  | wc -l
84
$ sudo apt-get install -s libxi6 | grep "^Inst"  | wc -l
0

Is there a better way?

lacostej · 2017-08-08T06:52:10Z

Short answer no, but what good is it to install something that won't work?

I am not sure I want the question: "do you want to install?" everytime.
An alternative would be to check if there are already some linux versions installed. If not, we could ask. But I don't like to mix the other version presents detection code down the installer. I would prefer an option to the method being passed down (auto_install_deps: true/false). WDYT?

That's why I thought that validation for each library would be better, as a user could specify to
skip some of them, knowing they're already present, or not willing to update them.
Alternatively, we could either keep track of what has been installed or try to fetch installed
libraries before trying to install them.

I prefer the current alternative where I don't want to install all of them. The package manager knows if the packages are there or not. We are not checking version number either. So it's a one shot attempt at getting everything in place.

return and UI.error then?

If it's explicit installation by the user, fail. If it's automatic try installing them, error and return.

I'm not sure there is a really better way, it seems to be a well known check. The usecases of
people having installed dpkg on a rpm-based os (which has no point as .deb files are Debian
specific) is too small (in my opinion at least) to have an impact on this. Then again, there may be
a far better check that I'm not aware of! Nothing is written in stone anyways, so my current check
could be swapped easily.

I agree it's a small case. I would prefer maybe something like

if not packaging system specified
try auto-detecting
if can't
....

I'll try to find a solution for that

OK

I still think we could have a separate action for installing the deps from the CLI to cover the cases.

lacostej · 2017-09-02T17:59:00Z

I propose we merge this in the following way.

we add the missing libpq5
we add an API so that we can call programmatically something like
U3d::LinuxDependencies.install(type: :rpm)
We don't integrate the call at install time
we optionally provide a command. But I can live without this right now.

My objective is to be able to test this on master easily. WDYT?

niezbop · 2017-09-04T07:14:34Z

Seems really good to me! I'll work on doing that.

Add all Unity dependencies and an API to install them. No command is available right now to install them.

lacostej · 2017-09-02T17:20:23Z

lib/u3d/installer.rb

+  class LinuxDependencies
+    DEPENDENCIES = [
+      'gconf-service',
+      'lib32gcc1',


I wonder if the dependencies marked like that will be good enough.

E.g. The doc states things like

debconf (>= 0.5) | debconf-2.0

lacostej · 2017-09-04T19:47:22Z

lib/u3d/commands.rb

@@ -129,6 +129,15 @@ def install(args: [], options: {})
        Installer.install_modules(files, definition.version, installation_path: options[:installation_path])
      end

+      def install_linux_dependencies(options: {})


install_dependencies ?

lacostej · 2017-09-04T19:48:28Z

lib/u3d/commands_generator.rb

@@ -148,6 +148,15 @@ def run
        end
      end

+      command :dependencies do |c|
+        c.syntax = 'u3d dependencies [-p | --package_manager <package manager>]'
+        c.description = 'Installs Unity dependencies. [Linux only]'


summary + description. We can be more verbose on the description part. In particular

detail how it works for detecting the package_manager, etc.

link to Linux forum post

explain how we deal with things like debconf (>= 0.5) | debconf-2.0

the fact we only implement the default deps, and not the ones for platforms (WebGL, etc)

lacostej · 2017-09-04T19:48:53Z

lib/u3d/commands_generator.rb

+      command :dependencies do |c|
+        c.syntax = 'u3d dependencies [-p | --package_manager <package manager>]'
+        c.description = 'Installs Unity dependencies. [Linux only]'
+        c.option '-p', '--package_manager STRING', String, 'Specify which package manager to use (aptitude, rpm...)'


option is unused right now, correct? If so remove it.

Proposed implementation, currently in this PR:

def self.install(prefix: nil) unless prefix if `which dpkg` != '' prefix = 'apt-get -y install' elsif `which rpm` != '' prefix = 'yum -y install' else raise 'Cannot install dependencies on your Linux distribution' end end if UI.interactive? return unless UI.confirm "Install dependencies? (#{DEPENDENCIES.length} dependency(ies) to install)" end U3dCore::CommandExecutor.execute(command: "#{prefix} #{DEPENDENCIES.join(' ')}", admin: true) end

lacostej · 2017-09-04T20:18:46Z

lib/u3d/commands_generator.rb

+        c.syntax = 'u3d dependencies [-p | --package_manager <package manager>]'
+        c.summary = 'Installs Unity dependencies. [Linux only]'
+        c.description = %(
+          #{c.summary}


Do we need to remove the front spaces here? Not sure how %( behaves.

lacostej · 2017-09-04T20:19:21Z

lib/u3d/commands_generator.rb

+        c.description = %(
+          #{c.summary}
+
+          Regarding the package manager: if none if specified, u3d will try to assume it by seeing which one.s is.are installed.


various typos.

lacostej · 2017-09-04T20:20:34Z

lib/u3d/commands_generator.rb

+          Regarding the dependencies themselves: only dependencies for the editor are installed. WebGL, Android and Tizen require others that you will have to install manually.
+          More on that: https://forum.unity3d.com/threads/unity-on-linux-release-notes-and-known-issues.350256/
+                  )
+        c.option '-p', '--package_manager STRING', String, 'Specify which package manager to use (apt-get, yum...)'


do you really want to use it with -p yum ?

Not a great option, but it was the least bad I could think of. Any suggestion?

lacostej · 2017-09-05T14:42:40Z

lib/u3d/commands_generator.rb

+Regarding the package manager: if none is specified, u3d will try to assume it by testing which one.s is.are installed.
+Only apt-get and yum are tested right now.
+
+If several package manager are installed on your machine simultaneously, we recommend that you specify the one you want to use.


typo: managers

lacostej · 2017-09-05T14:43:18Z

lib/u3d/commands_generator.rb

+
+If several package manager are installed on your machine simultaneously, we recommend that you specify the one you want to use.
+
+Regarding the dependencies themselves: only dependencies for the editor are installed. WebGL, Android and Tizen require others that you will have to install manually.


will that work if user doesn't specify -p "apt-get -y" ?

I.e. do we manage input properly?

Not working properly right now, I'm correcting that

lacostej · 2017-09-05T14:58:32Z

lib/u3d/commands_generator.rb

+Regarding the dependencies themselves: only dependencies for the editor are installed. WebGL, Android and Tizen require others that you will have to install manually.
+More on that: https://forum.unity3d.com/threads/unity-on-linux-release-notes-and-known-issues.350256/
+                  )
+        c.option '-p', '--package_manager STRING', String, 'Specify which package manager to use (apt-get, yum...)'


lacostej · 2017-09-05T14:58:36Z

lib/u3d/commands_generator.rb

@@ -148,6 +148,23 @@ def run
        end
      end

+      command :dependencies do |c|
+        c.syntax = 'u3d dependencies [-p | --package_manager <package manager>]'


niezbop mentioned this pull request Aug 5, 2017

Fix various Linux issues related to the installer and to the runner. #22

Closed

lacostej added the enhancement label Aug 5, 2017

niezbop force-pushed the linux_dependencies branch 2 times, most recently from 7cb70ea to ba4b9f3 Compare September 4, 2017 19:20

Add Linux dependencies definition

f97c79a

Add all Unity dependencies and an API to install them. No command is available right now to install them.

niezbop force-pushed the linux_dependencies branch from ba4b9f3 to f97c79a Compare September 4, 2017 19:27

lacostej approved these changes Sep 4, 2017

View reviewed changes

niezbop added 2 commits September 4, 2017 21:42

Accept package manager as argument in linux dependencies

1dbf94b

Add command to install dependencies on Linux

ce1f364

lacostej reviewed Sep 4, 2017

View reviewed changes

Improve command description

1e46967

niezbop force-pushed the linux_dependencies branch from af445d2 to 1e46967 Compare September 4, 2017 20:28

lacostej reviewed Sep 5, 2017

View reviewed changes

niezbop added 3 commits September 5, 2017 16:43

Change Commands API for linux dependencies

bc38272

Fix typo

329daee

PR feedback modifications

1d0400d

niezbop force-pushed the linux_dependencies branch from f72f29c to 1d0400d Compare September 5, 2017 14:57

lacostej reviewed Sep 5, 2017

View reviewed changes

Documentation modifications

4098f64

niezbop changed the title ~~Add Linux dependencies~~ u3d/dependencies: Add command to install Linux dependencies Sep 5, 2017

lacostej changed the title ~~u3d/dependencies: Add command to install Linux dependencies~~ u3d/dependencies: add command to install Linux dependencies Sep 5, 2017

niezbop merged commit 3d2eb75 into DragonBox:master Sep 5, 2017

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

u3d/dependencies: add command to install Linux dependencies #25

u3d/dependencies: add command to install Linux dependencies #25

niezbop commented Aug 5, 2017

lacostej commented Aug 5, 2017

niezbop commented Aug 5, 2017

lacostej commented Aug 6, 2017

lacostej commented Aug 8, 2017

lacostej commented Sep 2, 2017

niezbop commented Sep 4, 2017

lacostej Sep 2, 2017

lacostej Sep 4, 2017

lacostej Sep 4, 2017

niezbop Sep 4, 2017

lacostej Sep 4, 2017

niezbop Sep 4, 2017 •

edited

Loading

lacostej Sep 4, 2017

lacostej Sep 4, 2017

lacostej Sep 4, 2017

niezbop Sep 4, 2017

lacostej Sep 5, 2017

lacostej Sep 5, 2017

niezbop Sep 5, 2017

lacostej Sep 5, 2017

lacostej Sep 5, 2017


		If several package manager are installed on your machine simultaneously, we recommend that you specify the one you want to use.

		Regarding the dependencies themselves: only dependencies for the editor are installed. WebGL, Android and Tizen require others that you will have to install manually.

u3d/dependencies: add command to install Linux dependencies #25

u3d/dependencies: add command to install Linux dependencies #25

Conversation

niezbop commented Aug 5, 2017

lacostej commented Aug 5, 2017

niezbop commented Aug 5, 2017

lacostej commented Aug 6, 2017

lacostej commented Aug 8, 2017

lacostej commented Sep 2, 2017

niezbop commented Sep 4, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

niezbop Sep 4, 2017 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

niezbop Sep 4, 2017 •

edited

Loading