Move duplicated data_path out of U3d::Cache/U3d::INIparser to U3dCore::Helper #266
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lacostej
reviewed
Mar 15, 2018
| @@ -31,11 +31,7 @@ module U3d | |||
| class Cache | |||
| using ::CoreExtensions::OperatingSystem | |||
|
|
|||
| # Path to the directory containing the cache for the different OS | |||
| DEFAULT_LINUX_PATH = File.join(ENV['HOME'], '.u3d').freeze | |||
There was a problem hiding this comment.
in theory this is breaking APIs :)
There was a problem hiding this comment.
Would it be better to have something like
DEFAULT_LINUX_PATH = U3dCore::Helper.data_path
... (same for windows and mac)There was a problem hiding this comment.
Let's say for this time we don't care.
lacostej
approved these changes
Mar 26, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist
bundle exec rspecto make sure that my PR didn't break any testbundle exec rubocopto make sure that my PR is inline with our code stylePull Request Description
Move the duplicated data_path into a helper method so that it is only defined once, and can be used elsewhere.