Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

u3d/available: Make Linux 2018.3.0f2 available on linux #337 #338

Merged
merged 2 commits into from
Jan 8, 2019
Merged

u3d/available: Make Linux 2018.3.0f2 available on linux #337 #338

merged 2 commits into from
Jan 8, 2019

Conversation

tony-rowan
Copy link
Contributor

Pull Request Checklist

  • My pull request has been rebased on master
  • I ran bundle exec rspec to make sure that my PR didn't break any test
  • I ran bundle exec rubocop to make sure that my PR is inline with our code style
  • I have read the code of conduct

Pull Request Description

Fixes #337, making 2018.3.0f2 available on Linux. It does this by also searching the forum pages directly for LINUX_DOWNLOAD. It also allows the download link to be encompassed in single or double quotes.

I've tested on my Mac that u3d available -o linux responds with the latest version and extended the rspecs to cover this case. I have not yet tested on a linux system that the download and install completes successfully. I will do this when I next have access to a linux system - should be able to on Monday.

Copy link
Member

@niezbop niezbop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @rawstacktech ! It looks good for me. Nice change with the data.scan it makes thing more readable.

Let's wait just a bit to check that this works on Linux (I'd be surprised if it doesn't though) if you have access to one, I currently don't!

@tony-rowan
Copy link
Contributor Author

Tested it on my Linux machine, looks good. Also fixed a small typo in referencing a helper in the LinuxInstallationHelper. Looks like it only triggered when install multiple packages at a time.

Copy link
Member

@lacostej lacostej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rawstacktech thanks a lot for the contribution!

Really appreciated!

@lacostej lacostej merged commit 4efbb83 into DragonBox:master Jan 8, 2019
@tony-rowan tony-rowan deleted the fix/new-linux-versions branch January 8, 2019 22:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants