Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing error when installing Unity 2020 version in Linux #410

Merged
merged 3 commits into from
Apr 13, 2022
Merged

Fixing error when installing Unity 2020 version in Linux #410

merged 3 commits into from
Apr 13, 2022

Conversation

DiegoTorresSED
Copy link
Contributor

Pull Request Checklist

  • My pull request has been rebased on master
  • I ran bundle exec rspec to make sure that my PR didn't break any test
  • I ran bundle exec rubocop to make sure that my PR is inline with our code style
  • I have read the code of conduct

Pull Request Description

[DESCRIBE YOUR PULL REQUEST HERE]
This pull request solves the error when installing in Linux a Unity version 2020. It seems that untill Unity 2019, the unity_builtin_extra file has the string version coded at byte position 20. In 2020 the string version is coded from byte position 48. It has been coded a check for trying reading what it is expected in 2019 and if it is "\x00" set the seek position for 2020.

@DiegoTorresSED DiegoTorresSED changed the title <SUBJECT> Fixing error when installing Unity 2020 version in Linux Fixing error when installing Unity 2020 version in Linux Mar 31, 2021
@chazix
Copy link

chazix commented Feb 9, 2022

I came across needing this fix for my utilization with 2020 as well, thanks & this works well!

@lacostej
Copy link
Member

Thanks @DiegoTorresSED Completely missed that PR.
Will look into this now.

@lacostej lacostej requested review from niezbop and lacostej April 12, 2022 13:49
@lacostej
Copy link
Member

Looks OK to me.

Copy link
Member

@niezbop niezbop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me as well! Thanks for doing that @DiegoTorresSED

@lacostej lacostej merged commit 4801911 into DragonBox:master Apr 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants