Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix installation of modules for non latest releases #416

Merged
merged 5 commits into from
Apr 12, 2022

Conversation

lacostej
Copy link
Member

@lacostej lacostej commented Apr 7, 2022

Pull Request Description

We know that non-latest releases don't have their optional modules available. This is an attempt to fix it.

Looks like it works.

$ bundle console
 U3d::Commands.list_available(options: {unity_version: '2020.3.10f1', packages: 1})
Version 2020.3.10f1: https://download.unity3d.com/download_unity/297d780c91bc/
Packages:
 - Unity
 - Mono
 - Visualstudio
 - Android
 - Ios
 - Appletv
 - Linux-il2cpp
 - Linux-mono
 - Mac-il2cpp
 - Webgl
 - Windows-mono
 - Lumin
 - Documentation
 - Language-ja
 - Language-ko
 - Language-zh-hans
 - Language-zh-hant
 - Android-sdk-ndk-tools
 - Android-sdk-platform-tools
 - Android-sdk-build-tools
 - Android-sdk-platforms
 - Android-ndk
 - Android-open-jdk
 => ["2020.3.10f1"] 

U3d::Commands.install(args: ["2020.3.26f1"], options:{download: true, all: true, install:true})
/Users/lacostej/Code/OSS/u3d/.bundle/ruby/2.7.0/gems/json-2.1.0/lib/json/common.rb:156: warning: Using the last argument as keyword parameters is deprecated
/Users/lacostej/Code/OSS/u3d/.bundle/ruby/2.7.0/gems/json-2.1.0/lib/json/common.rb:156: warning: Using the last argument as keyword parameters is deprecated
/Users/lacostej/Code/OSS/u3d/.bundle/ruby/2.7.0/gems/json-2.1.0/lib/json/common.rb:156: warning: Using the last argument as keyword parameters is deprecated
Unity 2020.3.26f1 is already installed
Mono for Visual Studio for Mac depends on VisualStudio, but it's neither installed nor being installed.
Root privileges are required
Password for lacostej:
*********
No credentials storage available
Password for lacostej:
*********
No credentials storage available
Password for lacostej:
*********
No credentials storage available
Unity 2020.3.26f1 is already downloaded
Android Build Support is already downloaded
Android NDK is already downloaded
OpenJDK is already downloaded
Android SDK & NDK Tools is already downloaded
Android SDK Build Tools is already downloaded
Android SDK Platform Tools is already downloaded
Android SDK Platforms 29 is already downloaded
Android SDK Platforms 30 is already downloaded
tvOS Build Support is already downloaded
Documentation is already downloaded
iOS Build Support is already downloaded
日本語 is already downloaded
한국어 is already downloaded
简体中文 is already downloaded
繁體中文 is already downloaded
Linux Build Support (IL2CPP) is already downloaded
Linux Build Support (Mono) is already downloaded
Lumin OS (Magic Leap) Build Support is already downloaded
Mac Build Support (IL2CPP) is already downloaded
Mono for Visual Studio for Mac is already downloaded
Visual Studio for Mac is already downloaded
WebGL Build Support is already downloaded
Windows Build Support (Mono) is already downloaded
--------------------------------------------
--- Installing Unity 2020.3.26f1 (unity) ---
--------------------------------------------
Installing with /Users/lacostej/Downloads/Unity_Packages/2020.3.26f1/Unity.pkg
$ installer -pkg /Users/lacostej/Downloads/Unity_Packages/2020.3.26f1/Unity.pkg -target /
Failed to install pkg at /Users/lacostej/Downloads/Unity_Packages/2020.3.26f1/Unity.pkg: Exit status: 1
--------------------------------------------------
--- Installing Android Build Support (android) ---
--------------------------------------------------
Installing with /Users/lacostej/Downloads/Unity_Packages/2020.3.26f1/UnitySetup-Android-Support-for-Editor-2020.3.26f1.pkg
$ installer -pkg /Users/lacostej/Downloads/Unity_Packages/2020.3.26f1/UnitySetup-Android-Support-for-Editor-2020.3.26f1.pkg -target /
Successfully installed package from /Users/lacostej/Downloads/Unity_Packages/2020.3.26f1/UnitySetup-Android-Support-for-Editor-2020.3.26f1.pkg
--------------------------------------------
--- Installing Android NDK (android-ndk) ---
--------------------------------------------
Installing with /Users/lacostej/Downloads/Unity_Packages/2020.3.26f1/android-ndk-r19-darwin-x86_64.zip
$ stat -f "%Su,%A" /Applications/Unity_2020.3.26f1/PlaybackEngines/AndroidPlayer
$ whoami
$ chown lacostej: /Applications/Unity_2020.3.26f1/PlaybackEngines/AndroidPlayer
$ chmod u+w /Applications/Unity_2020.3.26f1/PlaybackEngines/AndroidPlayer
$ chown root: /Applications/Unity_2020.3.26f1/PlaybackEngines/AndroidPlayer
$ chmod 755 /Applications/Unity_2020.3.26f1/PlaybackEngines/AndroidPlayer
Successfully unizpped android-ndk-r19-darwin-x86_64.zip at /Applications/Unity_2020.3.26f1/PlaybackEngines/AndroidPlayer/NDK
---------------------------------------------
--- Installing OpenJDK (android-open-jdk) ---
---------------------------------------------
[...]

@lacostej lacostej force-pushed the fix/modules/non_latest_release branch from adbd030 to 951ceb5 Compare April 7, 2022 14:57
@lacostej lacostej requested a review from niezbop April 7, 2022 14:58
@lacostej lacostej changed the title Fix/modules/non latest release Fix installation of modules for non latest releases Apr 7, 2022
@niezbop
Copy link
Member

niezbop commented Apr 7, 2022

Looks good!

@lacostej lacostej merged commit c4eaeb4 into master Apr 12, 2022
@lacostej lacostej deleted the fix/modules/non_latest_release branch April 12, 2022 13:48
jlsalmon added a commit to jlsalmon/u3d that referenced this pull request Aug 25, 2022
DragonBox#416 seems to have introduced a bug where an attempt is made to call a method named `info` on the UI interface, but this method doesn't exist. This PR simply changes the call to `UI.message` instead.

Fixes DragonBox#430
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants