u3d/install: do not try to download unknown versions (i.e. not in cache) #57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lacostej
requested changes
Aug 8, 2017
lib/u3d/commands.rb
Outdated
| @@ -106,6 +106,10 @@ def download(args: [], options: {}) | |||
|
|
|||
| cache = Cache.new(force_os: os) | |||
| versions = cache[os.id2name]['versions'] | |||
| unless versions[version] | |||
There was a problem hiding this comment.
This is too early. It won't work for non interpreted version. E.g. latest.
|
Because the user could make a typo! Say one tries to install the version 56.1f1 (not 5.6.1.f1), it will still ask for credentials. |
lacostej
reviewed
Aug 9, 2017
lib/u3d/commands.rb
Outdated
| @@ -107,6 +107,10 @@ def download(args: [], options: {}) | |||
| cache = Cache.new(force_os: os) | |||
| versions = cache[os.id2name]['versions'] | |||
| version = interpret_latest(version, versions) | |||
| unless versions[version] | |||
| UI.error "No version #{version} was found in cache" | |||
There was a problem hiding this comment.
Version #{version} was not found. Either it doesn't exist or u3d doesn't know about it yet. Try refreshing with u3d available -f
|
Log message updated! |
u3d was going pretty far in the download process before realizing the version was not in the cache, and returning. It returns now way earlier.
niezbop
force-pushed
the
checkversionincache
branch
from
4cf6b4d to
c3f2d37
Compare
lacostej
changed the title
lacostej
approved these changes
Aug 9, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
u3d was going pretty far in the download process before realizing the version was not in the cache, and returning. It returns now way earlier.