Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

u3d/run: add -projectpath also when passing arguments (fixes #73) #80

Merged
merged 2 commits into from
Aug 24, 2017
Merged

u3d/run: add -projectpath also when passing arguments (fixes #73) #80

merged 2 commits into from
Aug 24, 2017

Conversation

lacostej
Copy link
Member

No description provided.

@lacostej lacostej force-pushed the test_command_run branch 7 times, most recently from a243ce1 to 9aa7fc1 Compare August 23, 2017 19:09
@lacostej lacostej changed the title WIP commands.run tests u3d/run: add -projectpath also when passing arguments (fixes #73) Aug 23, 2017
@lacostej lacostej requested a review from niezbop August 23, 2017 19:14
niezbop
niezbop requested changes Aug 23, 2017
View reviewed changes
Copy link
Member

@niezbop niezbop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I believe that the tests should be on another commit though as they do not directly deal with this specific run option.

@lacostej
Copy link
Member Author

@niezbop without the change 2 of the new tests fail:

image

the commit is very similar to what we did in 5246f29 (added tests, fixed a bug)

@niezbop
Copy link
Member

niezbop commented Aug 24, 2017

Okay. Accepted then!

@lacostej lacostej merged commit 5022a15 into DragonBox:master Aug 24, 2017
@lacostej lacostej deleted the test_command_run branch August 24, 2017 07:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@niezbop niezbop niezbop approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lacostej @niezbop