Check MBR Shadow during TakeOwnership #456
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
At this point in time, utility is taking ownership with provided password successfully with two classes of drives. 1. That supports MBRShadowing 2. That does not support MBRShadowing However, for those drives that does not support MBRSHadowing, it reports error and tool's return code is non zero despite taking ownership. This patch is to improve experience by checking MBRShadow capability (decoded with discovery0) prior to enable MBR.
Note: No functionality change expected with this commit.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At this point in time, utility is taking ownership with provided password successfully with two classes of drives.
However, for those drives that does not support MBRSHadowing, it reports error and tool's return code is non zero despite taking ownership.
This patch is to improve experience by checking MBRShadow capability (decoded with discovery0) prior to enable MBR.