Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proof of Concept: CSS library #97

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Proof of Concept: CSS library #97

wants to merge 2 commits into from

Conversation

TanguyDucky
Copy link
Contributor

@TanguyDucky TanguyDucky commented Apr 11, 2023

This branch is a PoC showing how to generate 1 (or many) CSS file(s) that can be used to style default web elements.

Take a look at css-library.html in which we demonstrate the usage on some (basic) components: button, avatar, card.

Note that to fully start using this kind of CSS library, we would need to rework some of our SASS files:

  • remove :host styles
  • make default style as easy to use as possible
  • make sure to prefix all classes with plmg-
  • figure out a way to mark out which component should be included in the library
    • ignore the components that don't work using pure CSS only

Asana task: https://app.asana.com/0/1200489836971088/1204369990653823/f

@github-actions
Copy link

Visit the preview URL for this PR (updated for commit 205028f):

https://test-auth-d13f2--pr97-poc-css-library-475xjnfr.web.app

(expires Tue, 18 Apr 2023 12:59:00 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: a53008a19f55b467e8188c6bc46d7c436559b643

jamesducky

This comment was marked as off-topic.

@jamesducky jamesducky dismissed their stale review April 12, 2023 07:57

because I am an idiot

@TanguyDucky TanguyDucky marked this pull request as draft April 12, 2023 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants