Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: mobile display #205

Merged
merged 3 commits into from
Oct 26, 2022
Merged

fix: mobile display #205

merged 3 commits into from
Oct 26, 2022

Conversation

mathiasayivor
Copy link
Collaborator

Fixes Issue

**My PR closes #204 **

👨‍💻 Changes proposed(What did you do ?)

  • Improvements on mobile display

✔️ Check List (Check all the applicable boxes)

  • My code follows the code style of this project.
  • This PR does not contain plagiarized content.
  • The title and description of the PR is clear and explains the approach.

Note to reviewers

📷 Screenshots

@vercel
Copy link

vercel bot commented Oct 25, 2022

Someone is attempting to deploy a commit to a Personal Account owned by @Dun-sin on Vercel.

@Dun-sin first needs to authorize it.

github-actions[bot]
github-actions bot reviewed Oct 25, 2022
View reviewed changes
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Compliance Checks

Thank you for your Pull Request! We have run several checks on this pull request in order to make sure it's suitable for merging into this project. The results are listed in the following section.

Watched Files

This pull request modifies specific files that require careful review by the maintainers.

Files Matched

  • package-lock.json

@Dun-sin
Copy link
Owner

Dun-sin commented Oct 25, 2022

Why is the changes so large? 🤔

@mathiasayivor
Copy link
Collaborator Author

Why is the changes so large? thinking

Most of the changes are class changes and the rest are lib function modifications.

@Dun-sin
Copy link
Owner

Dun-sin commented Oct 25, 2022

Why is the changes so large? thinking

Most of the changes are class changes and the rest are lib function modifications.

Just for mobile responsiveness?

@mathiasayivor
Copy link
Collaborator Author

Why is the changes so large? thinking

Most of the changes are class changes and the rest are lib function modifications.

Just for mobile responsiveness?

Yep.

@Dun-sin
Copy link
Owner

Dun-sin commented Oct 26, 2022

I don't think this request solves one thing, I'm seeing end search and some none other related things in there.

Can you break them into branches and issues, for me to easily review

@mathiasayivor
Copy link
Collaborator Author

Aight, here's a breakdown of all the changes I made:

  • I added @rsuite/icons library for Anonymous.jsx menu buttons (lines 85-95, 110-125, 134)

  • Moved isSearching && currentChatId status to context in order to use it for hiding the navbar when chatting with a user:
    Before:
    Screen Shot 2022-10-26 at 06 59 27
    Screen Shot 2022-10-26 at 06 58 29

    After:
    Screen Shot 2022-10-26 at 07 00 01
    Screen Shot 2022-10-26 at 06 57 41

  • Added endSearch && startSearch methods to help update isSearching && currentChatId values in context

  • Used the createClassesFromArray util to help add multiple classes in a readable manner (vue style)

  • Updated loadingText to be properly displayed on mobile devices (BuddyMatcher.jsx line 36-51)

  • The rest is just CSS class updates

@mathiasayivor
Copy link
Collaborator Author

I'm seeing end search and some none other related things in there.

@Dun-sin besides endSearch and the changes I've explained above, what other none related things do you see?

@Dun-sin
Copy link
Owner

Dun-sin commented Oct 26, 2022

I'm seeing end search and some none other related things in there.

@Dun-sin besides endSearch and the changes I've explained above, what other none related things do you see?

that's all i could notice

@mathiasayivor
Copy link
Collaborator Author

I'm seeing end search and some none other related things in there.

@Dun-sin besides endSearch and the changes I've explained above, what other none related things do you see?

that's all i could notice

Aight.
But is my explanation clear enough?

@Dun-sin
Copy link
Owner

Dun-sin commented Oct 26, 2022

I'm seeing end search and some none other related things in there.

@Dun-sin besides endSearch and the changes I've explained above, what other none related things do you see?

that's all i could notice

Aight. But is my explanation clear enough?

yes it's clear, thanks

@mathiasayivor mathiasayivor mentioned this pull request Oct 26, 2022
Merged
3 tasks
@vercel
Copy link

vercel bot commented Oct 26, 2022 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
whisper ✅ Ready (Inspect) Visit Preview Oct 26, 2022 at 1:06PM (UTC)

@Dun-sin Dun-sin merged commit 62eafcc into Dun-sin:main Oct 26, 2022
@mathiasayivor mathiasayivor deleted the fix/mobile-display branch October 26, 2022 13:08
Dun-sin added a commit that referenced this pull request Oct 26, 2022
@Dun-sin @ays14
@ayush-pingsafe @mathiasayivor
merge (#216)
1776777 
* feat: added button to stop searching for a buddy (#208)

* feat: added button to stop searching for a buddy

* add changes to remove user from waiting list

* Update BuddyMatcher.jsx

Co-authored-by: ayush-pingsafe <[email protected]>

* fix: mobile display (#205)

* chore: install @rsuite/icons package

* fix: mobile display

Co-authored-by: Ayush Sharma <[email protected]>
Co-authored-by: ayush-pingsafe <[email protected]>
Co-authored-by: Mathias Ayivor <[email protected]>
Dun-sin added a commit that referenced this pull request Oct 26, 2022
@Dun-sin @ays14
@ayush-pingsafe @mathiasayivor
merge (#229)
88623e2 
* feat: added button to stop searching for a buddy (#208)

* feat: added button to stop searching for a buddy

* add changes to remove user from waiting list

* Update BuddyMatcher.jsx

Co-authored-by: ayush-pingsafe <[email protected]>

* fix: mobile display (#205)

* chore: install @rsuite/icons package

* fix: mobile display

* fix: maintain the same state between navigation (#215)

* fix: update context when stop btn is clicked (#224)

* fix: users can navigate whiles chatting on mobile (#226)

Co-authored-by: Ayush Sharma <[email protected]>
Co-authored-by: ayush-pingsafe <[email protected]>
Co-authored-by: Mathias Ayivor <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@Dun-sin Dun-sin Dun-sin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Current mobile display is bad
2 participants
@mathiasayivor @Dun-sin