Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chat error #587

Closed
wants to merge 13 commits into from
Closed

Chat error #587

wants to merge 13 commits into from

Conversation

MJinH
Copy link

@MJinH MJinH commented Jan 12, 2024

Fixes Issue

**My PR closes #586 **

πŸ‘¨β€πŸ’» Changes proposed(What did you do ?)

fixed the error where the chat wasn't displaying, and the issue where messages weren't being delivered when the other user sent.
fixed name and type errors

βœ”οΈ Check List (Check all the applicable boxes)

  • My code follows the code style of this project.
  • This PR does not contain plagiarized content.
  • The title and description of the PR is clear and explains the approach.

Note to reviewers

πŸ“· Screenshots

chat_error.webm

Copy link

vercel bot commented Jan 12, 2024

Someone is attempting to deploy a commit to a Personal Account owned by @Dun-sin on Vercel.

@Dun-sin first needs to authorize it.

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Compliance Checks

Thank you for your Pull Request! We have run several checks on this pull request in order to make sure it's suitable for merging into this project. The results are listed in the following section.

Conventional Commit PR Title

In order to be considered for merging, the pull request title must match the specification in conventional commits. You can edit the title in order for this check to pass.
Most often, our PR titles are something like one of these:

  • docs: correct typo in README
  • feat: implement dark mode"
  • fix: correct remove button behavior

Linting Errors

  • Found type "null", must be one of "feat","fix","docs","style","refactor","perf","test","build","ci","chore","revert"
  • No subject found

@Dun-sin
Copy link
Owner

Dun-sin commented Jan 12, 2024

@MJinH this PR is hard to review, i see things from your past PR in here, please close this and create a new one with only your current change related to the new issue

@MJinH MJinH closed this Jan 12, 2024
@MJinH MJinH deleted the chat_error branch January 12, 2024 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] chat isn't visible
3 participants