-
Notifications
You must be signed in to change notification settings - Fork 405
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#597-Bug-resolved #603
#597-Bug-resolved #603
Conversation
Someone is attempting to deploy a commit to a Personal Account owned by @Dun-sin on Vercel. @Dun-sin first needs to authorize it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR Compliance Checks
Thank you for your Pull Request! We have run several checks on this pull request in order to make sure it's suitable for merging into this project. The results are listed in the following section.
Protected Branch
In order to be considered for merging, the pull request changes must not be implemented on the "main" branch. This is described in our Contributing Guide. We are closing this pull request and we would suggest that you implement your changes as described in our Contributing Guide and open a new pull request.
Conventional Commit PR Title
In order to be considered for merging, the pull request title must match the specification in conventional commits. You can edit the title in order for this check to pass.
Most often, our PR titles are something like one of these:
- docs: correct typo in README
- feat: implement dark mode"
- fix: correct remove button behavior
Linting Errors
- Found type "null", must be one of "feat","fix","docs","style","refactor","perf","test","build","ci","chore","revert"
- No subject found
@ABHID10
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR can't be accepted as it doesn't fix the bug by trying to find the issue why the previous code wasn't working and just decided to create a new implementation for it.
If you are still interested in working on this issue, pls fix the bug and not add a new implementation. Check why settings.theme isn't working and fix that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please revert this back
@@ -1,4 +1,4 @@ | |||
import { useMemo } from 'react'; | |||
import { useMemo, useState } from 'react'; // Import useState |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is an unneeded comment
Fixes Issue
My PR closes #597
π¨βπ» Changes proposed(What did you do ?)
βοΈ Check List (Check all the applicable boxes)
Note to reviewers
π· Screenshots