Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Moved menu toggle into it's own component. #688

Merged
merged 2 commits into from
Aug 29, 2024

Conversation

Priyanshu-2005
Copy link
Contributor

@Priyanshu-2005 Priyanshu-2005 commented Aug 28, 2024

Fixes Issue

**My PR closes #660 **

πŸ‘¨β€πŸ’» Changes proposed(What did you do ?)

Moved menu toggle into it's own component MenuToggle.jsx.

βœ”οΈ Check List (Check all the applicable boxes)

  • My code follows the code style of this project.
  • This PR does not contain plagiarized content.
  • The title and description of the PR is clear and explains the approach.

Note to reviewers

Added the screen Recording of menu toggle working.

πŸ“· Screenshots

Screen Recordings

Screencast.from.29-08-24.10.48.52.AM.IST.webm
Screencast.from.29-08-24.10.48.14.AM.IST.webm

Copy link

vercel bot commented Aug 28, 2024

Someone is attempting to deploy a commit to the dunsin's projects Team on Vercel.

A member of the Team first needs to authorize it.

Copy link

vercel bot commented Aug 29, 2024

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

Name Status Preview Comments Updated (UTC)
whisper-b2p2 βœ… Ready (Inspect) Visit Preview πŸ’¬ Add feedback Aug 29, 2024 7:52am

Copy link
Owner

@Dun-sin Dun-sin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You did great, thanks for contributing, I hope you will stick around and continue to contribute to this project.

Consider giving this project a star, sharing the project with your friends, and joining the community discord server if you haven't for more resources and opportunities to connect with others. πŸ‘‰πŸ½hereπŸ‘ˆπŸ½

@Dun-sin Dun-sin merged commit e509318 into Dun-sin:main Aug 29, 2024
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE] move menu toggle into it's own component
2 participants