Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(github-actions): add Prettier auto-correct for lint issues on PRs #714

Merged
merged 9 commits into from
Oct 22, 2024

Conversation

joshua-jinu
Copy link
Contributor

Fixes Issue

My PR closes #711

πŸ‘¨β€πŸ’» Changes proposed(What did you do ?)

  • Addition of formatting using Prettier and ESLint on Pull Requests using Github Actions.

βœ”οΈ Check List (Check all the applicable boxes)

  • My code follows the code style of this project.
  • This PR does not contain plagiarized content.
  • The title and description of the PR is clear and explains the approach.

Note to reviewers

πŸ“· Screenshots

Copy link

vercel bot commented Oct 21, 2024

@joshua-jinu is attempting to deploy a commit to the dunsin's projects Team on Vercel.

A member of the Team first needs to authorize it.

@joshua-jinu joshua-jinu changed the title ci(github-actions): add Prettier auto-correct for lint issues on PRs #711 ci(github-actions): add Prettier auto-correct for lint issues on PRs (#711) Oct 21, 2024
@Dun-sin
Copy link
Owner

Dun-sin commented Oct 21, 2024

@joshua-jinu your lint fails

@Dun-sin
Copy link
Owner

Dun-sin commented Oct 21, 2024

did you use chatgpt? looks like you didn't study the project structure to do this

.github/workflows/prettier-eslint.yml Outdated Show resolved Hide resolved
.github/workflows/prettier-eslint.yml Outdated Show resolved Hide resolved
.github/workflows/prettier-eslint.yml Outdated Show resolved Hide resolved
@joshua-jinu
Copy link
Contributor Author

Hey @Dun-sin , I've made the changes, could you please review them

@joshua-jinu joshua-jinu requested a review from Dun-sin October 22, 2024 04:15
@Dun-sin Dun-sin changed the title ci(github-actions): add Prettier auto-correct for lint issues on PRs (#711) ci(github-actions): add Prettier auto-correct for lint issues on PRs Oct 22, 2024
Copy link
Owner

@Dun-sin Dun-sin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You did great, thanks for contributing, I hope you will stick around and continue to contribute to this project.

Consider giving this project a star, sharing the project with your friends, and joining the community discord server if you haven't for more resources and opportunities to connect with others. πŸ‘‰πŸ½hereπŸ‘ˆπŸ½

@Dun-sin Dun-sin merged commit 6f41531 into Dun-sin:main Oct 22, 2024
2 of 3 checks passed
@joshua-jinu
Copy link
Contributor Author

Thank you @Dun-sin, looking forward to work on more such PRs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE] add prettier to github actions
2 participants