feat: add a dialog if User denies notfication permission #737
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
@AdarshKumar02291 is attempting to deploy a commit to the dunsin's projects Team on Vercel. A member of the Team first needs to authorize it. |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
AdarshKumar02291
changed the title
Dun-sin
changed the title
Dun-sin
reviewed
Dec 12, 2024
|
@AdarshKumar02291 i see your suggestion, i will merge this, can you please create a new issue based on your suggestion, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes Issue
**My PR closes #730 **
👨💻 Changes proposed(What did you do ?)
Changed the response of notification trigger function . Added a dialog if the user denies the permission .
✔️ Check List (Check all the applicable boxes)
Note to reviewers
I would suggest to first show the dialog and then request for permission .
📷 Screenshots