Library sidebar uses unique React keys (#592)

* Library sidebar uses unique React keys * Fix SCAN_START and SCAN_STOP actions
Dusk-Labs · Dec 10, 2023 · 19e68e0 · 19e68e0
1 parent 3a5f225
commit 19e68e0
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/ui/src/Components/Sidebar/Libraries.jsx b/ui/src/Components/Sidebar/Libraries.jsx
@@ -55,7 +55,7 @@ function Libraries() {
 
   // FETCH_LIBRARIES_OK
   if (fetched && !error && items.length > 0) {
-    libs = items.map((props, i) => <Library {...props} key={i} />);
+    libs = items.map((props) => <Library {...props} key={props.id} />);
   }
 
   if (libraries.items.length === 0) return null;

diff --git a/ui/src/reducers/library.js b/ui/src/reducers/library.js
@@ -196,12 +196,12 @@ export default function libraryReducer(state = initialState, action) {
     case SCAN_START:
       return {
         ...state,
-        scanning: [...scanning, action.id],
+        scanning: [...state.scanning, action.id],
       };
     case SCAN_STOP:
       return {
         ...state,
-        scanning: scanning.filter((id) => id !== action.id),
+        scanning: state.scanning.filter((id) => id !== action.id),
       };
     default:
       return state;