New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle undefined callbacks in setters on iOS native module #1015

Open

onurersel wants to merge 1 commit into DylanVann:main from onurersel:bugfix/handle-undefined-callbacks-ios

onurersel commented Nov 14, 2023

Sequence of events that ends up with crash are:

Set one of the callback with a function (ie. onError)
Try to load an invalid image, that will result with onError callback being called.
Set onError callback to undefined.

At this point, native iOS module tries to call the undefined function, which crashes the app with EXT_BAD_ACCESS.

This PR updates all setter functions and checks if the callback function exists before calling them.


          Handle undefined callbacks in setters on iOS native module

65bce37

Yann-prak mentioned this pull request

Handle undefined callbacks ios dream-sports-labs/react-native-fast-image#5

Merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet