Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove message commands and rewrite code implementation and functions #56

Merged
merged 74 commits into from
Jun 30, 2023

Conversation

JoshuaSlui
Copy link
Member

@JoshuaSlui JoshuaSlui commented Jun 28, 2023

This pull request provides readability, documentation and rewrites of the code, functions, commands and methods we use.
To be precise, this pull request handles:

  • Changing contact mail in SECURITY.md
  • Removing unnecessary utils.respond & help_CMD functions
  • Fixes code formatting for readability
  • Applies PEP8 conventions everywhere
  • Removes obsolete imports
  • Adds documentation to (some) functions
  • Adds functions to handle database queries
    • Modifier
    • Selector
  • Adds venv to .gitignore
  • Adjusts code to use new utility folder & relevant files/functions
  • Fixes @Soapy7261's spelling mistakes
  • Fixes markdown files, primarily tables
  • Fixes blacklisted servers still being able to add Pingernos
  • Allows deleting setserver servers from database by not providing a server
  • Adds check_ip function using regex
  • Actually require a server IP in checkip
  • ⚠️ Complete migration to slash commands

When approved and merged, PR 56 will mark release 3.0.0.
After release 3.0.0, we will start releasing appropriately for all new commits.

@JoshuaSlui
Copy link
Member Author

The Pull Request now fully migrates all commands to slash commands, implements additional features that simplifies, and decreases the amount of code needed. When this Pull Request is reviewed, we can work on applying the DRY (Don't Repeat Yourself) principle to all the code.

@JoshuaSlui JoshuaSlui marked this pull request as ready for review June 29, 2023 10:52
@JoshuaSlui JoshuaSlui changed the title Remove slash commands and rewrite code implementation and functions Remove message commands and rewrite code implementation and functions Jun 29, 2023
Copy link
Contributor

@zortos293 zortos293 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

few things that need to be fixed

cogs/checkip.py Outdated Show resolved Hide resolved
cogs/setserver.py Outdated Show resolved Hide resolved
JoshuaSlui and others added 2 commits June 30, 2023 16:36
Co-authored-by: Zortos <[email protected]>
Co-authored-by: Zortos <[email protected]>
@JoshuaSlui JoshuaSlui requested a review from zortos293 June 30, 2023 14:36
Copy link
Contributor

@zortos293 zortos293 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Forgot the ephemeral on the error's

my bad ;)

cogs/setserver.py Outdated Show resolved Hide resolved
cogs/setserver.py Outdated Show resolved Hide resolved
cogs/status.py Outdated Show resolved Hide resolved
cogs/status.py Outdated Show resolved Hide resolved
cogs/status.py Outdated Show resolved Hide resolved
cogs/checkip.py Outdated Show resolved Hide resolved
cogs/checkip.py Outdated Show resolved Hide resolved
JoshuaSlui and others added 7 commits June 30, 2023 17:08
Co-authored-by: Zortos <[email protected]>
Co-authored-by: Zortos <[email protected]>
Co-authored-by: Zortos <[email protected]>
Co-authored-by: Zortos <[email protected]>
Co-authored-by: Zortos <[email protected]>
@JoshuaSlui JoshuaSlui requested a review from zortos293 June 30, 2023 15:10
@zortos293
Copy link
Contributor

Good to go 👍

@zortos293 zortos293 merged commit 1b463eb into Python Jun 30, 2023
@zortos293 zortos293 deleted the rewrite branch June 30, 2023 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants