Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix guild logs #59

Merged
merged 4 commits into from
Aug 15, 2023
Merged

Fix guild logs #59

merged 4 commits into from
Aug 15, 2023

Conversation

JoshuaSlui
Copy link
Member

@JoshuaSlui JoshuaSlui commented Aug 15, 2023 •
edited
Loading

Fixes IndexErrors within the sql statements checking blacklist statuses, this was the cause for guild joins and leaves not being logged.

@JoshuaSlui JoshuaSlui requested a review from Soapy7261 August 15, 2023 17:42
Soapy7261
Soapy7261 approved these changes Aug 15, 2023
View reviewed changes
Copy link
Contributor

@Soapy7261 Soapy7261 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

don't bother asking for my review when its sql related, all ill do is just approve

@JoshuaSlui
Copy link
Member Author

I kinda still gotta ask because i cant merge without a review lol

@JoshuaSlui JoshuaSlui merged commit 493f135 into Python Aug 15, 2023
@JoshuaSlui JoshuaSlui deleted the fix-guild-logs branch August 15, 2023 17:57
@JoshuaSlui
Copy link
Member Author

Want me to ask a review from @ToothyDev for sql-related things from now on?

@Soapy7261
Copy link
Contributor

Yes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Soapy7261 Soapy7261 Soapy7261 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JoshuaSlui @Soapy7261