General minor code fixup / overhaul #67
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Well, apparently since I created this branch from another branch and not main, it shows that branch's commits here too - not sure if good or bad but that's how it is now.. welp |
on both ? |
JoshuaSlui
requested changes
Apr 10, 2024
|
In the future, i'd like to prevent these PRs, they're great but they shouldn't be necessary. |
JoshuaSlui
approved these changes
Apr 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I went through all the main files and tried unifying used concepts, typehints, simplifying imports, etc.
All changes are cosmetic and no behavior was intentionally changed.
If any change I made isn't wanted or could be done even better, do comment
This PR depends on both #64