-
Notifications
You must be signed in to change notification settings - Fork 636
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Homepage tests refactor #15078
Draft
dnenov
wants to merge
10
commits into
DynamoDS:master
Choose a base branch
from
dnenov:homepage-tests-refactor
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+230
−204
Draft
Homepage tests refactor #15078
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
cf6971c
simplify tests
dnenov aef2603
Merge remote-tracking branch 'upstream/master' into homepage-tests-re…
dnenov fb3bcec
leave all but 1 test
dnenov 732394e
Merge remote-tracking branch 'upstream/master' into homepage-tests-re…
dnenov 915bf96
unique user data folder
dnenov dbe49f9
dynWebView.CoreWebView2.Environment.UserDataFolder failing
dnenov 6cd83a1
Merge remote-tracking branch 'upstream/master' into homepage-tests-re…
dnenov 84d10cd
ignoring tests again, remove old code
dnenov 3168b22
revert homePage under test mode
dnenov 24ca262
Merge remote-tracking branch 'upstream/master' into homepage-tests-re…
dnenov File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you might be able to use this event
dynWebView.CoreWebView2.Environment.BrowserProcessExited
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, great, I can definitely do that. Thank you for the suggestion.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
probably have to clean it up too..