Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge master_cl-localization into master_cl #15815

Open
wants to merge 1 commit into
base: master_cl
Choose a base branch
from

Conversation

escbuild
Copy link
Collaborator

@escbuild escbuild commented Feb 7, 2025

Hi , could you please review and merge this PR?

================== Word Count Statistics begin ==================

GMT Sat Feb 15 09:52:45 2025: Localization Engineer Lead for this PR is [email protected],[email protected].

Vendor Engineer for this PR is [email protected].

Localization branch is updated.
New/Updated strings status
CHS: 28 strings (299 words) are in English
CHT: 28 strings (299 words) are in English
CSY: 28 strings (299 words) are in English
DEU: 28 strings (299 words) are in English
ESP: 28 strings (299 words) are in English
FRA: 28 strings (299 words) are in English
ITA: 28 strings (299 words) are in English
JPN: 28 strings (299 words) are in English
KOR: 28 strings (299 words) are in English
PLK: 28 strings (299 words) are in English
PTB: 28 strings (299 words) are in English
RUS: 28 strings (299 words) are in English

Please note that If the word count above shows some words in English, it is because the localization team hasn't processed all the new/updated strings yet. These words will be translated in the next translation loop.

Please merge this PR anyway as it will align the localizable file(s) content with the English file(s) content and prevent any functionality issue caused from misaligned localized file(s) versus English file(s).

If you are about to release and you are concerned about these strings showing up in English, please contact your localization contact/project team. Thanks.

=================== Word Count Statistics end ==================

@@ -1,7 +1,7 @@
{
"Uuid": "3c9d0464-8643-5ffe-96e5-ab1769818209",
"IsCustomNode": false,
"Description": "Propojit uzly k přidání dvou čísel",
"Description": "Connect nodes to add two numbers",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ZbynekHanak-RWS I found the translation here are backwards, any chance we can fix that?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@QilongTang , I will look on the issue to see why all dyn files get untranslated. Thanks

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems this master_cl PR was created from the production translation database, where is currently NodeHelpFiles component only. I rerun align job from the translation database for master_cl branch which includes also .dyn and .resx files.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still does not look correct to me, maybe we can close this PR and do another sync from master_cl branch to master branch?

@escbuild escbuild force-pushed the master_cl-localization branch from c039534 to 55feaa0 Compare February 14, 2025 08:27
@escbuild escbuild requested a review from QilongTang February 14, 2025 08:27
@escbuild escbuild force-pushed the master_cl-localization branch from 55feaa0 to 0ae18d0 Compare February 15, 2025 08:44
@escbuild
Copy link
Collaborator Author

This is a friendly reminder.

Hi @zeusongit, @QilongTang, @reddyashish,
This PR has been opened more than 2 days ago. Could you please merge it?

Thanks.

From build https://ls.jenkins.autodesk.com/job/CL/job/DynamoCore_CL/185/
Professional translation: all languages
Pseudo translation: none
@escbuild escbuild force-pushed the master_cl-localization branch from 0ae18d0 to 36b280c Compare February 15, 2025 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants