Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DYN-8276 XML Files Localization #15824

Open
wants to merge 3 commits into
base: master_cl
Choose a base branch
from

Conversation

RobertGlobant20
Copy link
Contributor

Purpose

Fix for copying the translated xml files to the output directory
In this change I've done the next:

  • Copy the xml generated in the OutputPath/en-US folder to Dynamo\doc\distrib\xml\en-US
  • Add a Copy Task in DynamoCoreWpf project to update the files Dynamo\doc\distrib\xml\en-US (just in case the documentation in cs file was updated).
  • Add a Copy Task in DynamoCoreWpf for copying the translated xml files to a specific location.
    e.g. Dynamo\doc\distrib\xml\es-ES to OutputPath\es-ES

Declarations

Check these if you believe they are true

  • The codebase is in a better state after this PR
  • Is documented according to the standards
  • The level of testing this PR includes is appropriate
  • User facing strings, if any, are extracted into *.resx files
  • All tests pass using the self-service CI.
  • Snapshot of UI changes, if any.
  • Changes to the API follow Semantic Versioning and are documented in the API Changes document.
  • This PR modifies some build requirements and the readme is updated
  • This PR contains no files larger than 50 MB

Release Notes

Fix for copying the translated xml files to the output directory

Reviewers

@QilongTang

FYIs

@reddyashish

Copying xml files to  doc\distrib\xml
Fixing xml locations and adding copy instruction in DynamoCore.csproj
I've moved the Copy Task to DynamoCoreWpf due that previous csproj files (like DynamoCore) were not taking the xml latest versions from the ouput en-US directory.
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See the ticket for this pull request: https://jira.autodesk.com/browse/DYN-8276

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant