fix bug in general schur eigenvalues computation #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #30 +/- ##
=======================================
Coverage 93.45% 93.45%
=======================================
Files 9 9
Lines 596 596
=======================================
Hits 557 557
Misses 39 39
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
louisponet
reviewed
Dec 3, 2022
|
I don't think that the doctests need to be modified. My change doesn't modify the API, only the content of ws.eigen_values that isn't tested in the doctests |
|
Yea some of the printed values showed to be different, but I guess it’s not an issue then. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The generalized eigenvalues are (alpha_r[j] + alpha_i[j])/beta[j]