40 use css variables for general design #86
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Albert Hald <[email protected]>
Co-authored-by: Arnar Freyr <[email protected]>
Co-authored-by: Albert Hald <[email protected]>
Co-authored-by: Arnar Freyr <[email protected]>
Co-Authored-By: Arnar Freyr <[email protected]>
Co-authored-by: Nyby <[email protected]>
commit a48c0a7 Author: Anton <[email protected]> Date: Fri Oct 20 11:29:34 2023 +0200 Update dependencies To fix a dependency mismatch commit f417b36 Author: tr0ub1eM4k3r <[email protected]> Date: Thu Oct 19 15:07:29 2023 +0200 Console (#45) * Changed SvelteKit version, trying to fix dependacy error * Added button for expanding footer * Made button for collapsing/expanding console Co-authored-by: tr0ub1eM4k3r <[email protected]> * Made basic console functionality, including: Collapsible console, Multiple tabs which you can switch between, Line component for messages and errors Co-authored-by: SolarEarth37 <[email protected]> * Added simple css for tab buttons Co-authored-by: SolarEarth37 <[email protected]> * Made console collapse button larger Small inconsistencies fixed Co-authored-by: SolarEarth37 <[email protected]> * Changed ordering of functions and variables Combined two functions into a general one * FIxed weird formatting * Added functionality for sending errors to the console * Removed useless line of code * Made console more independent, and changed removed magic numbers * Removed console logs * Ran yarn format * Fixed issue where you could select the arrow * Formatting * Fixed issue where not all elements could be seen when resizing Fixed issue with topbar resizing when other elements on page changes * Formatting * consoleTab button now changes color on select * Added text wrapping in console Co-authored-by: SolarEarth37 <[email protected]> * Added a max height for the console * Made console resizeable Co-authored-by: SolarEarth37 <[email protected]> * Fixed console drag issue Now body is grid instead of flexbox Co-authored-by: tr0ub1eM4k3r <[email protected]> * Flex Solution Suggested flexbox solution * Made Arrow svg for collapse button * Used lint, and removed unused variables * Converted collapse-button image to standard Changed dimensions to match new image Removed "symbols" folder * Cleaned up, ready for check --------- Co-authored-by: SolarEarth37 <[email protected]> Co-authored-by: tr0ub1eM4k3r <[email protected]> Co-authored-by: SolarEarth37 <[email protected]> Co-authored-by: Skrome <[email protected]>
Co-authored-by: Arnar Freyr <[email protected]>
Co-authored-by: Arnar Freyr <[email protected]>
Co-authored-by: Albert Hald <[email protected]>
Co-authored-by: @AlbertHald <[email protected]>
…les-for-general-design
✅ Deploy Preview for ecdar ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
Closed as the merge commit made horrible changes to the commit history - R.I.P |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About
This pull request contains the initial implementation of the dynamic loading of CSS colors (And other CSS properties) and is the foundation for one of the features requested by the PO.
The specific feature is the one in-which users should be able to change the color-scheme by themselves.
Features implemented:
Link to MDN docs for mediaQuery selector