Switched protobuffer build script to new lib

[KamyaPA]

Removed submodule Ecdar-Protobuf
Removed build.rs
Added dependency Ecdar-Protobuf-rs

[Aavild]

fixed merge conflict

[williamwoldum]

Maybe I've missed something, and let me know if thats the case

Removing the submodule pointer from Reveaal seriously harms the flexibility of protobuf development/implementation.

With this PR, if i wanted to work with a different Ecdar-Protobuf branch in Reveaal I would have to fork Ecdar-Protobuf-rs, update the submodule pointer, and update Cargo.toml to the forked repo.

While this might be okay for Reveaal where the protobuf services are fairly stable, it would be a major pain when working with the Ecdar-API where new services and messages are added frequently.

If Ecdar-Protobuf-rs does not work as a common protobuf-build-solution for all repos, and harms development, Im not sure i see the benefit of using it.

[Aavild]

I think you may be right. Also given that we want yet another submodule pointer in #19

[KamyaPA]

Maybe I've missed something, and let me know if thats the case

Removing the submodule pointer from Reveaal seriously harms the flexibility of protobuf development/implementation.

With this PR, if i wanted to work with a different Ecdar-Protobuf branch in Reveaal I would have to fork Ecdar-Protobuf-rs, update the submodule pointer, and update Cargo.toml to the forked repo.

While this might be okay for Reveaal where the protobuf services are fairly stable, it would be a major pain when working with the Ecdar-API where new services and messages are added frequently.

If Ecdar-Protobuf-rs does not work as a common protobuf-build-solution for all repos, and harms development, Im not sure i see the benefit of using it.

I've added this functionality in Ecdar-Protobuff-rs such that you can compile with any root folder by setting an environment variable

[williamwoldum]

I've added this functionality in Ecdar-Protobuff-rs such that you can compile with any root folder by setting an environment variable

I see how this works around the issue, but we are over-complicating things.

I don't really want to download Ecdar-ProtoBuf next to Reveaal and then configure the absolute path in Ecdar-Protobuff-rs.

I think Ecdar-Protobuff-rs is trying to solve a problem that does not exist.

Sure, it provides a common build.rs file and a common serde macro, but even build.rs should not necessarily be the same for every repo. For Ecdar-API we might want to add attributes via build.rs that are not relevant for Reveaal.

Further if i wanted to add new stuff to the common build.rs during development, i would still have to fork Ecdar-Protobuff-rs and update Cargo.toml to apply any changes.

✌️