Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Grid-based particle initialization and random init rewrite #609

Merged
merged 9 commits into from
Sep 1, 2023

Conversation

streeve
Copy link
Member

@streeve streeve commented Feb 20, 2023

  • Both uniform and random creation from Cajita grids
  • Updates the core library init to make it more similar (type tags and non-uniform box). Behavior changes to ignore particles for the variants with minimum particle separation (and therefore may not return the number of particles requested)
  • Deprecates previous simple random init versions (these still loop until all particles have been created which is extremely slow)

Core versions should also accept ParticleList + user init functors done

@streeve streeve added the enhancement New feature or request label Feb 20, 2023
@streeve streeve self-assigned this Feb 20, 2023
@streeve streeve mentioned this pull request May 18, 2023
@streeve streeve requested a review from abisner May 25, 2023 18:19
@streeve streeve force-pushed the particle_init_cajita branch from 7b4d8e1 to 09c272e Compare June 22, 2023 17:48
@streeve streeve changed the title Grid-based particle initialization Grid-based particle initialization and random init rewrite Jun 22, 2023
@streeve
Copy link
Member Author

streeve commented Jun 22, 2023

@abisner this is finally ready for review

@streeve streeve force-pushed the particle_init_cajita branch from 71b7854 to 8e94682 Compare June 30, 2023 20:55
@streeve
Copy link
Member Author

streeve commented Jul 28, 2023

Now blocked by #654

@streeve streeve force-pushed the particle_init_cajita branch 2 times, most recently from d2f0deb to 64f1001 Compare August 2, 2023 20:40
@streeve streeve force-pushed the particle_init_cajita branch from 64f1001 to 9d7212f Compare August 11, 2023 17:46
@streeve streeve force-pushed the particle_init_cajita branch 2 times, most recently from 23a2500 to d0025ab Compare August 15, 2023 12:55
@streeve
Copy link
Member Author

streeve commented Aug 15, 2023

@abisner this actually passes all tests. I removed the filter empty routine for now because of SYCL issues, but I think it's best to revisit that later

@streeve streeve force-pushed the particle_init_cajita branch from d0025ab to a3763e5 Compare September 1, 2023 16:00
@streeve
Copy link
Member Author

streeve commented Sep 1, 2023

Failures unrelated

@streeve streeve merged commit fbbbb0a into ECP-copa:master Sep 1, 2023
@streeve streeve deleted the particle_init_cajita branch September 1, 2023 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request ready-for-review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants