-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Grid-based particle initialization and random init rewrite #609
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
7b4d8e1
to
09c272e
Compare
@abisner this is finally ready for review |
71b7854
to
8e94682
Compare
Now blocked by #654 |
d2f0deb
to
64f1001
Compare
64f1001
to
9d7212f
Compare
23a2500
to
d0025ab
Compare
@abisner this actually passes all tests. I removed the filter empty routine for now because of SYCL issues, but I think it's best to revisit that later |
lebuller
reviewed
Sep 1, 2023
lebuller
approved these changes
Sep 1, 2023
Co-authored-by: Stuart Slattery <[email protected]>
Deprecate previous versions
size will be wrong and would need filtering
d0025ab
to
a3763e5
Compare
Failures unrelated |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Core versions should also acceptdoneParticleList
+ user init functors