Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent "Parameter must be scalar" error when creating a calendar event #2

Closed
wants to merge 1 commit into from
Closed

Prevent "Parameter must be scalar" error when creating a calendar event #2

wants to merge 1 commit into from

Conversation

sbourget
Copy link

In version 16.1.20160715 when a user creates a calendar event, it fails with the following error in the apache logs (Apache 2.4.23, PHP 7.0.8):

An error happened (EGroupware\Api\Exception\WrongParameter): calendar_bo::resource_info(NULL) parameter must be scalar, referer: https://egroupware.XXXX.org/index.php?menuaction=calendar.calendar_uiforms.edit&date=20160719&hour=7&minute=30&owner[]=11
#0 C:\Web\sites\egroupware\calendar\inc\class.calendar_uiforms.inc.php(422): calendar_bo->resource_info(NULL), referer: https://egroupware.XXXX.org/index.php?menuaction=calendar.calendar_uiforms.edit&date=20160719&hour=7&minute=30&owner[]=11
#1 C:\Web\sites\egroupware\api\src\loader\deprecated_factory.php(191): calendar_uiforms->process_edit(Array), referer: https://egroupware.XXXX.org/index.php?menuaction=calendar.calendar_uiforms.edit&date=20160719&hour=7&minute=30&owner[]=11
#2 C:\Web\sites\egroupware\api\src\Etemplate.php(366): ExecMethod(Array, Array), referer: https://egroupware.XXXX.org/index.php?menuaction=calendar.calendar_uiforms.edit&date=20160719&hour=7&minute=30&owner[]=11
#3 [internal function]: EGroupware\Api\Etemplate::ajax_process_content('calendar_egroup...', Array, ''), referer: https://egroupware.sau19.org/index.php?menuaction=calendar.calendar_uiforms.edit&date=20160719&hour=7&minute=30&owner[]=11
C:\Web\sites\egroupware\api\src\Json\Request.php(179): call_user_func_array(Array, Array), referer: https://egroupware.XXXX.org/index.php?menuaction=calendar.calendar_uiforms.edit&date=20160719&hour=7&minute=30&owner[]=11
#5 C:\Web\sites\egroupware\api\src\Json\Request.php(91): EGroupware\Api\Json\Request->handleRequest('EGroupware\Api\...', Array), referer: https://egroupware.XXXX.org/index.php?menuaction=calendar.calendar_uiforms.edit&date=20160719&hour=7&minute=30&owner[]=11
#6 C:\Web\sites\egroupware\json.php(119): EGroupware\Api\Json\Request->parseRequest('EGroupware\Api\...', '{"request":{"pa...'), referer: https://egroupware.XXXX.org/index.php?menuaction=calendar.calendar_uiforms.edit&date=20160719&hour=7&minute=30&owner[]=11
#7 {main}, referer: https://egroupware.XXXX.org/index.php?menuaction=calendar.calendar_uiforms.edit&date=20160719&hour=7&minute=30&owner[]=11

Instance=default, User=egroupware, Request=POST https://egroupware.XXXX.org/json.php?menuaction=EGroupware\\Api\\Etemplate::ajax_process_content, User-agent=Mozilla/5.0 (Windows NT 6.1; Win64; x64; rv:47.0) Gecko/20100101 Firefox/47.0, referer: https://egroupware.XXXX.org/index.php?menuaction=calendar.calendar_uiforms.edit&date=20160719&hour=7&minute=30&owner[]=11

This occurs because the $participant has a value of null during one of the iterations of the foreach loop. This patch simply checks to see if there is a value before executing the code within the loop.

@ralfbecker
Copy link
Member

@nathangray Can you have a look at that pull request.

Ralf

@nathangray
Copy link
Contributor

Is there any difference between wrapping that whole thing in an if as compared to something like if(is_null($participant)) continue;?

@ralfbecker
Copy link
Member

No, does the same thing and does not indent the whole thing further.

@nathangray Please go ahead, implement that and close the PR.

@nathangray
Copy link
Contributor

Implemented, thanks @sbourget

@nathangray nathangray closed this Jul 25, 2016
ralfbecker added a commit that referenced this pull request Apr 10, 2017
@ralfbecker
fix PHP warning : array_diff_key(): Argument #2 is not an array on li…
25b4c53 
…ne 281
ralfbecker added a commit that referenced this pull request Apr 10, 2017
@ralfbecker
fix PHP warning : array_diff_key(): Argument #2 is not an array on li…
17a7356 
…ne 281
Lankaster added a commit to Lankaster/egroupware that referenced this pull request Jan 4, 2019
@Lankaster
Additionals checks:
e967c95 
Error examples:
[Thu Jan 03 13:11:34.043522 2019] [:error] [pid 18181] [client 192.168.1.100:38306] PHP Warning: array_intersect(): Argument EGroupware#2 is not an array in /usr/share/egroupware/calendar/inc/class.calendar_groupdav.inc.php on line 818, referer: http://egroupware/egroupware/groupdav.php/ABC/calendar/
[Thu Jan 03 13:59:41.125066 2019] [:error] [pid 18364] [client 192.168.1.100:40350] PHP Warning: Invalid argument supplied for foreach() in /usr/share/egroupware/api/src/Etemplate/Widget/Nextmatch.php on line 314, referer: http://egroupware/egroupware/index.php?cd=yes
@Lankaster Lankaster mentioned this pull request Jan 4, 2019
Closed
This was referenced Mar 5, 2019
Merged
Merged
Merged
Merged
@asig2016 asig2016 mentioned this pull request Apr 1, 2019
Merged
ralfbecker added a commit that referenced this pull request Apr 7, 2021
@ralfbecker
fix some PHP 8 errors in calendar: in_array() Argument #2 must be of …
2d046e2 
…type array, null given
ralfbecker added a commit that referenced this pull request Sep 24, 2021
@ralfbecker
fix PHP 8.0 error: implode(): Argument #2 ($array) must be of type ?a…
d9f759f 
…rray, string given
ralfbecker added a commit that referenced this pull request Sep 24, 2021
@ralfbecker
fix PHP 8.0 error: implode(): Argument #2 ($array) must be of type ?a…
9babcdf 
…rray, string given
ralfbecker added a commit that referenced this pull request Oct 4, 2021
@ralfbecker
fix PHP 8.0 Warning: Argument #2 of array_merge must be of type array…
1cd5755 
…, boolean given
ralfbecker added a commit that referenced this pull request Oct 4, 2021
@ralfbecker
fix PHP 8.0 Warning: Argument #2 of array_merge must be of type array…
eebc939 
…, boolean given
ralfbecker added a commit that referenced this pull request Oct 5, 2021
@ralfbecker
fix PHP 8.0 Error: Argument #2 ($array) must be of type array, null g…
66cf807 
…iven
ralfbecker added a commit that referenced this pull request Oct 5, 2021
@ralfbecker
fix PHP 8.0 Error: Argument #2 ($array) must be of type array, null g…
e5427ef 
…iven
ralfbecker added a commit that referenced this pull request Oct 7, 2021
@ralfbecker
fix PHP 8.0 error "array_key_exists(): Argument #2 ($array) must be o…
7c4914d 
…f type array, null given" when creating a category
ralfbecker added a commit that referenced this pull request Oct 7, 2021
@ralfbecker
fix PHP 8.0 error "array_key_exists(): Argument #2 ($array) must be o…
088dab1 
…f type array, null given" when creating a category
nathangray added a commit that referenced this pull request Oct 13, 2021
@nathangray
PHP 8.0: Avoid fatal error "array_key_exists(): Argument #2 ($array) …
4fdefd6 
…must be of type array, null given"
nathangray added a commit that referenced this pull request Oct 14, 2021
@nathangray
Fix PHP 8 error: "array_search(): Argument #2 ($haystack) must be of …
c8843f8 
…type array, null given"
nathangray added a commit that referenced this pull request Oct 14, 2021
@nathangray
PHP 8.0: Avoid fatal error "array_key_exists(): Argument #2 ($array) …
f8fd87c 
…must be of type array, null given"
nathangray added a commit that referenced this pull request Oct 14, 2021
@nathangray
Fix PHP 8 error: "array_search(): Argument #2 ($haystack) must be of …
506a9bb 
…type array, null given"
nathangray added a commit that referenced this pull request Oct 22, 2021
@nathangray
Calendar: Fix PHP 8 error "array_key_exists(): Argument #2 ($array) m…
76e1e32 
…ust be of type array, null given"
nathangray added a commit that referenced this pull request Oct 22, 2021
@nathangray
Calendar: Fix PHP 8 error "array_key_exists(): Argument #2 ($array) m…
877d8b9 
…ust be of type array, null given"
ralfbecker added a commit that referenced this pull request Jan 25, 2023
@ralfbecker
fix error exporting LDAP accounts to SQL: array_key_exits parameter #2 …
e725961 
…must be of type array, bool given
ralfbecker added a commit that referenced this pull request Feb 6, 2023
@ralfbecker
fix explode(): Argument #2 ($string) must be of type string, array given
c48e2dc
ralfbecker added a commit that referenced this pull request Apr 27, 2023
@ralfbecker
fixing ValueError: str_repeat(): Argument #2 ($times) must be greater…
5db8883 
… than or equal to 0

fixes 1894a19
ralfbecker added a commit that referenced this pull request Apr 27, 2023
@ralfbecker
fixing ValueError: str_repeat(): Argument #2 ($times) must be greater…
5ef378a 
… than or equal to 0

fixes 1894a19
ralfbecker added a commit that referenced this pull request May 25, 2023
@ralfbecker
fix array_map(): Argument #2 ($array) must be of type array, int given
6dc1ae4
ralfbecker added a commit that referenced this pull request May 25, 2023
@ralfbecker
fix array_map(): Argument #2 ($array) must be of type array, int given
44df202
ralfbecker added a commit that referenced this pull request Jun 7, 2023
@ralfbecker
fix PHP TypeError: implode(): Argument #2 ($array) must be of type ?a…
f16cfd4 
…rray, int given
ralfbecker added a commit that referenced this pull request Jun 7, 2023
@ralfbecker
fix PHP TypeError: implode(): Argument #2 ($array) must be of type ?a…
956d56f 
…rray, int given
ralfbecker added a commit that referenced this pull request Jun 16, 2023
@ralfbecker
fix PHP TypeError: Argument #2 ($array) must be of type array, null g…
51ff3f1 
…iven
nathangray pushed a commit that referenced this pull request Aug 22, 2023
@ralfbecker @nathangray
fix array_map(): Argument #2 ($array) must be of type array, int given
3d834ff
nathangray pushed a commit that referenced this pull request Aug 22, 2023
@ralfbecker @nathangray
fix PHP TypeError: implode(): Argument #2 ($array) must be of type ?a…
fa29c9b 
…rray, int given
nathangray pushed a commit that referenced this pull request Aug 22, 2023
@ralfbecker @nathangray
fix PHP TypeError: Argument #2 ($array) must be of type array, null g…
36ce67b 
…iven
nathangray added a commit that referenced this pull request Oct 11, 2023
@nathangray
Calendar: Attempt to avoid error when accepting external invitation
6b4a131 
calendar_uiforms::event_changed(): Argument #2 ($_old) must be of type
array, bool given, called in
/var/www/epl-23.1/calendar/inc/class.calendar_uiforms.inc.php on line 2295
nathangray added a commit that referenced this pull request Oct 12, 2023
@nathangray
Calendar: Attempt to avoid error when accepting external invitation
5dfcfd2 
calendar_uiforms::event_changed(): Argument #2 ($_old) must be of type
array, bool given, called in
/var/www/epl-23.1/calendar/inc/class.calendar_uiforms.inc.php on line 2295
nathangray added a commit that referenced this pull request Oct 16, 2023
@nathangray
Calendar: Another attempt to avoid error when accepting external invi…
a84dd3d 
…tation

calendar_uiforms::event_changed(): Argument #2 ($_old) must be of type
array, bool given, called in
/var/www/epl-23.1/calendar/inc/class.calendar_uiforms.inc.php on line 2295
nathangray added a commit that referenced this pull request Oct 16, 2023
@nathangray
Calendar: Another attempt to avoid error when accepting external invi…
c1cb6db 
…tation

calendar_uiforms::event_changed(): Argument #2 ($_old) must be of type
array, bool given, called in
/var/www/epl-23.1/calendar/inc/class.calendar_uiforms.inc.php on line 2295
ralfbecker added a commit that referenced this pull request Oct 30, 2023
@ralfbecker
fix error ldap_get_entries(): Argument #2 ($result) must be of type L…
af633af 
…DAP\Result, bool given (0)
ralfbecker added a commit that referenced this pull request Oct 30, 2023
@ralfbecker
fix error ldap_get_entries(): Argument #2 ($result) must be of type L…
a4353ab 
…DAP\Result, bool given (0)
nathangray added a commit that referenced this pull request Mar 11, 2024
@nathangray
Et2Email: Fix search result required 2 down arrows to get result #2
6cd2d3e
nathangray added a commit that referenced this pull request Mar 12, 2024
@nathangray
Et2Email: Fix search result required 2 down arrows to get result #2
be4cc0e
ralfbecker added a commit that referenced this pull request Apr 3, 2024
@ralfbecker
fix Argument #2 ($old) must be of type ?array, bool given
30604b9
ralfbecker added a commit that referenced this pull request Apr 3, 2024
@ralfbecker
fix Argument #2 ($old) must be of type ?array, bool given
ffc6a53
ralfbecker added a commit that referenced this pull request Sep 11, 2024
@ralfbecker
fix array_key_exists() Argument #2 must be of type array, null given …
a4f2549 
…when trying to create a new iCal Import profile for Infolog
ralfbecker added a commit that referenced this pull request Sep 11, 2024
@ralfbecker
fix array_key_exists() Argument #2 must be of type array, null given …
5d491cf 
…when trying to create a new iCal Import profile for Infolog
ralfbecker added a commit that referenced this pull request Nov 6, 2024
@ralfbecker
fix Api\Accounts::hidden2account_id(): Argument #2 ($account_ids) mus…
a47809b 
…t be of type ?array, int given
ralfbecker added a commit that referenced this pull request Nov 6, 2024
@ralfbecker
fix Api\Accounts::hidden2account_id(): Argument #2 ($account_ids) mus…
2a8a2a8 
…t be of type ?array, int given
ralfbecker added a commit that referenced this pull request Nov 29, 2024
@ralfbecker
fix array_search(): Argument #2 ($haystack) must be of type array, in…
eb3ae5c 
…t given
ralfbecker added a commit that referenced this pull request Nov 29, 2024
@ralfbecker
fix array_search(): Argument #2 ($haystack) must be of type array, in…
ac1e1be 
…t given
ralfbecker added a commit that referenced this pull request Dec 4, 2024
@ralfbecker
fix array_search(): Argument #2 ($haystack) must be of type array, in…
35256b7 
…t given
ralfbecker added a commit that referenced this pull request Dec 4, 2024
@ralfbecker
fix array_search(): Argument #2 ($haystack) must be of type array, in…
7d5d25f 
…t given
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sbourget @ralfbecker @nathangray