Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cam6_4_067: Remove SPCAM #1217

Open
wants to merge 7 commits into
base: cam_development
Choose a base branch
from
Open

cam6_4_067: Remove SPCAM #1217

wants to merge 7 commits into from
+242 −100,114

Conversation

brian-eaton
Copy link
Collaborator

Resolve #1171 - Remove SP-CAM from cam_development

@brian-eaton brian-eaton added the BFB bit for bit tag label Jan 2, 2025
@brian-eaton brian-eaton self-assigned this Jan 2, 2025
@cacraigucar cacraigucar self-requested a review January 2, 2025 21:42
cacraigucar
cacraigucar requested changes Feb 13, 2025
View reviewed changes
Copy link
Collaborator

@cacraigucar cacraigucar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code changes all look good. I did a grep through the source code tree and saw SPCAM mentioned in ReleaseNotes. Since it says CAM5.4, and we didn't update it for CAM6, I'd say lets go ahead and remove that file completely.

@cacraigucar cacraigucar changed the title Remove SPCAM cam6_4_067: Remove SPCAM Feb 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cacraigucar cacraigucar cacraigucar requested changes

Requested changes must be addressed to merge this pull request.

Assignees

@brian-eaton brian-eaton

Labels
BFB bit for bit tag CoupledEval3
Projects
CAM Development
Status: No status
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@brian-eaton @cacraigucar