Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove nlev dependence for some namelist defaults #1255

Open
wants to merge 5 commits into
base: cam_development
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 5 additions & 9 deletions bld/namelist_files/namelist_defaults_cam.xml
Original file line number Diff line number Diff line change
Expand Up @@ -811,22 +811,18 @@
<pgwv waccmx="1">18</pgwv>

<!-- gravity wave settings -->
<effgw_beres_dp>0.7D0</effgw_beres_dp>
<effgw_beres_dp hgrid="0.9x1.25" >0.4D0</effgw_beres_dp>

<effgw_beres_dp >0.7D0</effgw_beres_dp>
<effgw_beres_dp model_top="lt" >0.30D0</effgw_beres_dp>
<effgw_beres_dp model_top="mt" >0.70D0</effgw_beres_dp>
<effgw_beres_dp hgrid="0.9x1.25" >0.4D0</effgw_beres_dp>
<effgw_beres_dp waccm_phys="0" >0.55D0</effgw_beres_dp>
<effgw_beres_dp waccm_phys="1" hgrid="0.9x1.25" >0.5D0</effgw_beres_dp>
<effgw_beres_dp waccm_phys="1" hgrid="ne30np4" nlev="70" >0.5D0</effgw_beres_dp>
<effgw_beres_dp waccm_phys="1" hgrid="ne30np4" nlev="110" >0.7D0</effgw_beres_dp>
<effgw_beres_dp chem="geoschem_mam4" hgrid="0.9x1.25" >0.5D0</effgw_beres_dp>
<effgw_beres_dp chem="trop_strat_mam4_vbs" hgrid="0.9x1.25" >0.5D0</effgw_beres_dp>
<effgw_beres_dp chem="trop_strat_mam4_vbsext" hgrid="0.9x1.25">0.5D0</effgw_beres_dp>
<effgw_beres_dp waccm_phys="1" hgrid="ne30np4" >0.5D0</effgw_beres_dp>
<effgw_beres_dp chem="geoschem_mam4" hgrid="0.9x1.25" >0.5D0</effgw_beres_dp>
<effgw_beres_dp chem="trop_strat_mam5_vbs" hgrid="0.9x1.25" >0.5D0</effgw_beres_dp>
<effgw_beres_dp chem="trop_strat_mam5_vbsext" hgrid="0.9x1.25">0.5D0</effgw_beres_dp>

<effgw_oro nlev="60" >0.0625D0</effgw_oro>

<effgw_rdg_resid >1.0D0</effgw_rdg_resid>

<effgw_rdg_beta >1.0D0</effgw_rdg_beta>
Expand Down
55 changes: 55 additions & 0 deletions doc/ChangeLog
Original file line number Diff line number Diff line change
@@ -1,5 +1,60 @@
===============================================================

Tag name:
Originator(s):
Date:
One-line Summary: remove dependence on nlev for some namelist defaults
Github PR URL:

Purpose of changes (include the issue number and title text for each relevant GitHub issue):

Resolve #819 - dependance of some namelist default on the number of
vertical levels (lev)?
- There are just two variables other than ncdata that have an nlev
attribute. Those entries can be removed because there are no compsets
that use them.

Describe any changes made to build system: none

Describe any changes made to the namelist: none

List any changes to the defaults for the boundary datasets: none

Describe any substantial timing or memory changes: none

Code reviewed by:

List all files eliminated: none

List all files added and what they do: none

List all existing files that have been modified, and describe the changes:

bld/namelist_files/namelist_defaults_cam.xml
. remove entry for effgw_oro w/ nlev=60
. remove entry effgw_beres_dp w/ nlev=110

If there were any failures reported from running test_driver.sh on any test
platform, and checkin with these failures has been OK'd by the gatekeeper,
then copy the lines from the td.*.status files for the failed tests to the
appropriate machine below. All failed tests must be justified.

derecho/intel/aux_cam:

derecho/nvhpc/aux_cam:

izumi/nag/aux_cam:

izumi/gnu/aux_cam:

CAM tag used for the baseline comparison tests if different than previous
tag:

Summarize any changes to answers: B4B

===============================================================
===============================================================

Tag name: cam6_4_064
Originator(s): sjsprecious, huebleruwm
Date: Feb 10, 2025
Expand Down