-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make usrf condition in is_in_active_grid consistent with other checks #40
Conversation
As per suggestions from Bill Lipscomb in ESCOMP#39, I am treating usrf == 0 as land rather than ocean. This makes the conditional here consistent with similar checks elsewhere in CISM.
I'm going ahead and merging this since it just does what we discussed in #39, and merging it will let me run testing in the context of CISM-wrapper. @whlipscomb feel free to comment after the fact if you want. |
I meant to mention: I checked the standard 4-km Greenland input file, and it has 70 grid cells with topg exactly equal to 0, and 50 grid cells with (topg + thk) (i.e., usrf) exactly equal to 0. So I expect small answer changes from this change. (I had been hoping that we could avoid answer changes in a Greenland case, but I don't feel that it's a big deal that it will change answers: I'll just want to look more closely at the differences to make sure there aren't any significant unforeseen consequences of this change.) |
@billsacks – I agree that small answer changes for Greenland aren't a big deal. I would hope that most or all of the points with topg = usrf = 0.0 are in the interior, surrounded by cells with usrf > 0. In that case, labeling them as land will reduce the chance of having weird logic errors. But if there are such points out in the ocean, we might have to give them a closer look. |
@billsacks – Thanks for the image. I think that reclassifying these points as land would be a good thing, or at least not a bad thing. |
Revert PR #40 This didn't work: it resulted in the ice mask being 1 everywhere. See #39 (comment) We'll fix this later (see #41)
Make usrf condition in is_in_active_grid consistent with other checks As per suggestions from Bill Lipscomb in #39, I am treating usrf == 0 as land rather than ocean. This makes the conditional here consistent with similar checks elsewhere in CISM.
Revert PR #40 This didn't work: it resulted in the ice mask being 1 everywhere. See #39 (comment) We'll fix this later (see #41)
As per suggestions from Bill Lipscomb in
#39, I am treating usrf == 0 as
land rather than ocean. This makes the conditional here consistent with
similar checks elsewhere in CISM.