Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

crop and grass snow burial #516

Closed
danicalombardozzi opened this issue Sep 19, 2018 · 0 comments · Fixed by #1112
Closed

crop and grass snow burial #516

danicalombardozzi opened this issue Sep 19, 2018 · 0 comments · Fixed by #1112
Labels
bug something is working incorrectly enhancement new capability or improved behavior of existing capability science Enhancement to or bug impacting science

Comments

@danicalombardozzi
Copy link
Contributor

Snow burial for all crop and grass PFTs is currently coded so that at a snow depth of 20 cm, crops and grasses are fully buried. However, this should be based on the height of the plant, and for crops and grasses, should also consider that the plants do fall over under the weight of snow. I recently ran simulations with an updated calculation of snow burial, and will create a fork to bring in this new code.
@billsacks billsacks added enhancement new capability or improved behavior of existing capability and removed type: enhance - science labels May 24, 2019
@wwieder wwieder added the bug something is working incorrectly label Aug 10, 2020
danicalombardozzi added a commit to danicalombardozzi/CTSM that referenced this issue Aug 19, 2020
@danicalombardozzi
Crop/grass snow burial changed based on height and lodging. Addresses…
6a155d6 
… issue ESCOMP#516
@danicalombardozzi danicalombardozzi mentioned this issue Aug 19, 2020
Merged
danicalombardozzi added a commit to danicalombardozzi/CTSM that referenced this issue Oct 8, 2020
@danicalombardozzi
Update to BGC code to account for crop/grass height in snow burial ca…
264f598 
…lculation, fix for bug ESCOMP#516
ekluzek added a commit to chrislxj/ctsm that referenced this issue Jan 27, 2021
@ekluzek
Merge tag 'ctsm5.1.dev014' into cn-matrix_v3
36f7cc1 
Grass/crop snow burial fraction fix, and some other fixes

(1) Crop/grass snow burial changed based on height and lodging (Danica
    Lombardozzi) - resolves ESCOMP#516. Updates grass and crop snow
    burial ('fb' in SatellitePhenologyMod.F90) from being 0.2m to change
    with PFT height and accounts for 20% lodging (falling over).

(2) In BGC code, make elai and esai depend on frac_sno (Danica
    Lombardozzi, Keith Oleson & Bill Sacks) - resolves ESCOMP#1116

(3) Fix to quadratic solution error bug caused by negative shaded
    photosynthesis (Danica Lombardozzi & Keith Oleson) - resolves
    ESCOMP#756

(4) Point to cime branch tag that avoids building CDEPS with LILAC, to
    avoid dependence on unreleased ESMF code (Bill Sacks) - resolves
    ESCOMP#1203

(5) Some tweaks to documentation and how the documentation is built
    (Bill Sacks)
@samsrabin samsrabin added the science Enhancement to or bug impacting science label Aug 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug something is working incorrectly enhancement new capability or improved behavior of existing capability science Enhancement to or bug impacting science
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Snow burial fix danicalombardozzi/CTSM
4 participants
@billsacks @wwieder @samsrabin @danicalombardozzi